Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IAM Policy Management): Added nest conditions to rule.conditions #218

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

swcolley
Copy link
Contributor

PR summary

Updated based on API definition fix to allow for conditions under rule.conditions.
Tests:

Examples:

mvn exec:java -Dexec.mainClass="com.ibm.cloud.platform_services.iam_policy_management.v1.IamPolicyManagementExamples"
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  24.119 s
[INFO] Finished at: 2023-10-30T16:23:38-04:00
[INFO] ------------------------------------------------------------------------

mvn clean install:

mvn clean install
...
[INFO] Reactor Summary for IBM Cloud Platform Services Java SDK 99-SNAPSHOT:
[INFO] 
[INFO] IBM Cloud Platform Services Java SDK ............... SUCCESS [  9.402 s]
[INFO] IBM Cloud Platform Services SDK Common Library ..... SUCCESS [  8.699 s]
[INFO] IBM Cloud Case Management API ...................... SUCCESS [ 18.270 s]
[INFO] IBM Cloud Catalog Management API ................... SUCCESS [ 24.074 s]
[INFO] IBM Cloud Context-Based Restrictions API ........... SUCCESS [ 17.666 s]
[INFO] IBM Cloud Enterprise Billing Units API ............. SUCCESS [ 16.079 s]
[INFO] IBM Cloud Enterprise Management API ................ SUCCESS [ 16.809 s]
[INFO] IBM Cloud Enterprise Usage Reports API ............. SUCCESS [ 15.552 s]
[INFO] IBM Cloud Global Catalog API ....................... SUCCESS [ 17.988 s]
[INFO] IBM Cloud Global Search and Tagging - Search API ... SUCCESS [ 15.384 s]
[INFO] IBM Cloud Global Search and Tagging - Tagging API .. SUCCESS [ 16.151 s]
[INFO] IBM Cloud IAM Access Groups API .................... SUCCESS [ 19.446 s]
[INFO] IBM Cloud IAM Identity Services API ................ SUCCESS [ 21.052 s]
[INFO] IBM Cloud IAM Policy Management API ................ SUCCESS [ 44.720 s]
[INFO] IBM Cloud Shell Account Settings API ............... SUCCESS [ 15.760 s]
[INFO] IBM Cloud Open Service Broker API .................. SUCCESS [ 16.290 s]
[INFO] IBM Cloud Resource Controller API (v2) ............. SUCCESS [ 18.286 s]
[INFO] IBM Cloud Resource Manager API ..................... SUCCESS [ 15.767 s]
[INFO] IBM Cloud Usage Metering API ....................... SUCCESS [ 15.388 s]
[INFO] IBM Cloud Usage Reports API ........................ SUCCESS [ 17.245 s]
[INFO] IBM Cloud User Management API ...................... SUCCESS [ 16.381 s]
[INFO] IBM Cloud Platform Services Test Coverage Reports .. SUCCESS [  1.954 s]
[INFO] IBM Cloud Platform Services Code Examples .......... SUCCESS [  6.255 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  06:24 min
[INFO] Finished at: 2023-10-30T15:45:20-04:00

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Updates Rule to allow for properties that are already allowed for in API.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

issue: https://github.ibm.com/IAM/AM-issues/issues/1908

@padamstx padamstx self-requested a review October 31, 2023 16:46
@padamstx padamstx self-assigned this Oct 31, 2023
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 653fdfa into main Oct 31, 2023
3 checks passed
@padamstx padamstx deleted the policyNestedConditions branch October 31, 2023 16:47
ibm-devx-sdk pushed a commit that referenced this pull request Oct 31, 2023
## [0.44.2](0.44.1...0.44.2) (2023-10-31)

### Bug Fixes

* **IAM Policy Management:** add nested conditions to rule.conditions ([#218](#218)) ([653fdfa](653fdfa))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.44.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants