Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Usage Reports): Update query param for getting reports snapshotlist #216

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

manukm-ibm
Copy link
Member

@manukm-ibm manukm-ibm commented Oct 18, 2023

PR summary

Add new query parameters to support pagination of API: /v1/billing-reports-snapshots

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pyrooka pyrooka self-assigned this Oct 18, 2023
@pyrooka pyrooka self-requested a review October 18, 2023 13:07
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pyrooka pyrooka merged commit 3dba623 into IBM:main Oct 18, 2023
2 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Oct 18, 2023
# [0.44.0](0.43.1...0.44.0) (2023-10-18)

### Features

* **Usage Reports:** Update query param for getting reports snapshot list ([#216](#216)) ([3dba623](3dba623))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.44.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants