Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IAM Policy Management): re-gen service after fix the template metadata as part of policies #213

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

Rajesh-Pirati
Copy link
Contributor

PR summary

Issue: https://github.ibm.com/IAM/AM-issues/issues/1803

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

integration tests

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running com.ibm.cloud.platform_services.iam_policy_management.v1.IamPolicyManagementIT
[INFO] Tests run: 25, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 23.157 s - in com.ibm.cloud.platform_services.iam_policy_management.v1.IamPolicyManagementIT
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 25, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- maven-failsafe-plugin:3.0.0-M7:verify (default) @ iam-policy-management ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  47.323 s
[INFO] Finished at: 2023-09-21T16:05:10+05:30
[INFO] ------------------------------------------------------------------------

Examples

getPolicyAssignment() result:
{
  "template_id": "policyTemplate-d7794ab2-8b43-42c1-9e0e-bb201def0c3a",
  "template_version": "2",
  "assignment_id": "TestingPolicyAssignment",
  "target_type": "Account",
  "target": "b766255a51c348c8ac8cd9350a54a40a",
  "options": [
    {
      "subject_type": "access_group_id",
      "subject_id": "AccessGroupId-7d0ba87b-325d-4857-ae02-d91f2af0bf79",
      "root_requester_id": "iam-ServiceId-ba2b6448-8559-485a-baf7-b244933b99ca",
      "root_template_id": "UpstremTemplate",
      "root_template_version": "2"
    }
  ],
  "id": "policyAssignment-71083d83-086b-4308-ada5-7279f1073fc6",
  "account_id": "872c19db5b1643a8b3a3ddd12763ec28",
  "href": "https://iam.cloud.ibm.com/v1/policy_assignments/policyAssignment-71083d83-086b-4308-ada5-7279f1073fc6",
  "created_at": "2023-08-25T14:32:30.837Z",
  "created_by_id": "iam-ServiceId-ba2b6448-8559-485a-baf7-b244933b99ca",
  "last_modified_at": "2023-08-25T14:32:30.978Z",
  "last_modified_by_id": "iam-ServiceId-ba2b6448-8559-485a-baf7-b244933b99ca",
  "resources": [
    {
      "target": "b766255a51c348c8ac8cd9350a54a40a",
      "policy": {
        "resource_created": {
          "id": "87fa6e0d-d9b7-4fa1-848e-7406a66239f3"
        }
      }
    }
  ],
  "status": "succeeded"
}
getTemplateMetaDataV2AccessPolicy() result:
{
  "id": "policyTemplate-d7794ab2-8b43-42c1-9e0e-bb201def0c3a",
  "version": "2",
  "assignment_id": "policyAssignment-71083d83-086b-4308-ada5-7279f1073fc6",
  "root_id": "UpstremTemplate",
  "root_version": "2"
}
deletePolicyTemplateVersion() response status code: 204
deletePolicyTemplate() response status code: 204
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  30.419 s
[INFO] Finished at: 2023-09-21T17:01:03+05:30
[INFO] ------------------------------------------------------------------------

…tadata as part of policies

Signed-off-by: Rajesh K Pirati <[email protected]>
@padamstx padamstx self-requested a review September 21, 2023 14:33
@padamstx padamstx self-assigned this Sep 21, 2023
@Rajesh-Pirati Rajesh-Pirati marked this pull request as ready for review September 25, 2023 14:08
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 4984f85 into main Sep 25, 2023
@padamstx padamstx deleted the policy-assignment-metadata branch September 25, 2023 16:51
ibm-devx-sdk pushed a commit that referenced this pull request Sep 25, 2023
# [0.43.0](0.42.1...0.43.0) (2023-09-25)

### Features

* **IAM Policy Management:** re-gen service after fix the template metadata as part of policies ([#213](#213)) ([4984f85](4984f85))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.43.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants