Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Context-Based Restrictions): add service group support to Operations #211

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

JonahFarc
Copy link
Contributor

PR summary

Adds service group support to operations

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

service_name parameter can now be replaced with the service group parameter.

Does this PR introduce a breaking change?

  • Yes
  • No

@JonahFarc
Copy link
Contributor Author

Unit Test Screenshot:
image

Integration Test Screenshot:
image

@padamstx padamstx self-requested a review September 13, 2023 14:46
@padamstx padamstx self-assigned this Sep 13, 2023
@JonahFarc
Copy link
Contributor Author

JonahFarc commented Sep 13, 2023

Examples Screenshot:
image

Copy link
Member

@soohoowoohoo soohoowoohoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonahFarc
Copy link
Contributor Author

Examples Screenshot:
image

Test Screenshot:
image

Integration Screenshot:
image

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 73a19fe into IBM:main Sep 15, 2023
ibm-devx-sdk pushed a commit that referenced this pull request Sep 15, 2023
# [0.42.0](0.41.0...0.42.0) (2023-09-15)

### Features

* **Context-Based Restrictions:** add service group support to operations ([#211](#211)) ([73a19fe](73a19fe))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.42.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@JonahFarc JonahFarc deleted the cbr-update branch September 15, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants