Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Usage Reports): regen usage reports with latest API def #185

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

Jdatechong
Copy link
Contributor

PR summary

Adds the currency_rate and pending fields to various API responses.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Various API response objects should now accurately include the currency_rate and pending fields.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Test results:

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running TestSuite
[INFO] Tests run: 62, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.789 s - in TestSuite
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 62, Failures: 0, Errors: 0, Skipped: 0

Integration test results:

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running com.ibm.cloud.platform_services.usage_reports.v4.UsageReportsIT
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.787 s - in com.ibm.cloud.platform_services.usage_reports.v4.UsageReportsIT
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- maven-failsafe-plugin:3.0.0-M7:verify (default) @ usage-reports ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] -----------------------------------------------------------------------

Examples:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 23.158 s
[INFO] Finished at: 2023-04-05T10:23:53-07:00
[INFO] ------------------------------------------------------------------------

Signed-off-by: Jonathan Date-chong <[email protected]>
@Jdatechong Jdatechong changed the title update usage reports API response fields fix(usage-reports): regen usage reports with latest API def Apr 5, 2023
@padamstx padamstx self-requested a review April 5, 2023 19:28
@padamstx padamstx self-assigned this Apr 5, 2023
@padamstx padamstx changed the title fix(usage-reports): regen usage reports with latest API def fix(Usage Reports): regen usage reports with latest API def Apr 5, 2023
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit dc1788c into IBM:main Apr 5, 2023
ibm-devx-sdk pushed a commit that referenced this pull request Apr 5, 2023
## [0.31.1](0.31.0...0.31.1) (2023-04-05)

### Bug Fixes

* **Usage Reports:** regen usage reports with latest API def ([#185](#185)) ([dc1788c](dc1788c))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.31.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants