Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add labels to examples #97

Merged
merged 35 commits into from
Mar 25, 2021
Merged

fix: add labels to examples #97

merged 35 commits into from
Mar 25, 2021

Conversation

Andras-Csanyi
Copy link
Contributor

@Andras-Csanyi Andras-Csanyi commented Mar 23, 2021 •
edited
Loading

PR summary

This PR adds labels to example output, so that it is easier to identify which section of the output belongs to which method.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Andras-Csanyi
fix(activity tracker): add labels to example output
edf9060
@Andras-Csanyi
fix(case management): add labels to example output
9b787fd
@Andras-Csanyi
fix(configuration governance): add spaces between "\n" and "%s" in pr…
7ad409e 
…intf methods for easier readability
@Andras-Csanyi
fix(enterprise billing units): add labels to example output
65d0758
@Andras-Csanyi
fix(enterprise usage report): add labels to example output
8403fe5
@Andras-Csanyi
fix(global catalog): add labels to example output
9cb8565
@Andras-Csanyi
fix(global search): add labels to example output
3ccce47
@Andras-Csanyi
fix(global tagging): add labels to example output
1bbdd97
@Andras-Csanyi
fix(iam access groups): add labels to example output
3bcdb7b
@Andras-Csanyi
fix(iam identity): add labels to example output
23d0011
@Andras-Csanyi
fix(iam policy management): add labels to example output
d53aea7
@Andras-Csanyi
fix(open service broker): add labels to example output
9af10f0
@Andras-Csanyi
fix(resource controller): add labels to example output
bf9e63c
@Andras-Csanyi
fix(resource manager): add labels to example output
f3ff4f8
@Andras-Csanyi
fix(usage metering): add labels to example output
8171084
@Andras-Csanyi
fix(usage reports): add labels to example output
6fedd70
@Andras-Csanyi
fix(user management): add labels to example output
25d347f
@Andras-Csanyi Andras-Csanyi self-assigned this Mar 23, 2021
pyrooka
pyrooka requested changes Mar 23, 2021
View reviewed changes
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the requested changes looks good. What do you think about the things I've mentioned?

casemanagementv1/case_management_v1_examples_test.go Outdated Show resolved Hide resolved
casemanagementv1/case_management_v1_examples_test.go Outdated Show resolved Hide resolved
atrackerv1/atracker_v1_examples_test.go Outdated Show resolved Hide resolved
padamstx
padamstx approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pyrooka
pyrooka approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@padamstx padamstx merged commit 35e8342 into main Mar 25, 2021
@padamstx padamstx deleted the fix-add-labels-to-examples branch March 25, 2021 13:57
ibm-devx-automation pushed a commit that referenced this pull request Mar 25, 2021
@semantic-release-bot
chore(release): 0.17.19 release notes [skip ci]
1c48d8a 
## [0.17.19](v0.17.18...v0.17.19) (2021-03-25)

### Bug Fixes

* add labels to examples ([#97](#97)) ([35e8342](35e8342))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.17.19 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

@pyrooka pyrooka pyrooka approved these changes

Assignees

@Andras-Csanyi Andras-Csanyi

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Andras-Csanyi @ibm-devx-automation @pyrooka @padamstx