Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Posture Management): add service to project #95

Merged
merged 12 commits into from
Mar 26, 2021
Merged

feat(Posture Management): add service to project #95

merged 12 commits into from
Mar 26, 2021

Conversation

pyrooka
Copy link
Member

@pyrooka pyrooka commented Mar 9, 2021

PR summary

This PR adds the Posture Management service to the project.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pyrooka pyrooka requested a review from padamstx March 9, 2021 16:37
@padamstx padamstx self-assigned this Mar 25, 2021
padamstx
padamstx requested changes Mar 25, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall... just a few minor changes needed.

posturemanagementv1/posture_management_v1_examples_test.go Outdated Show resolved Hide resolved
posturemanagementv1/posture_management_v1_integration_test.go Outdated Show resolved Hide resolved
@pyrooka
chore: resolve requested changes
43aa8a0 
1. Add labels to the print statements in the examples.

2. Remove core pointer functions from the integration tests.
@pyrooka pyrooka force-pushed the add-posture-management branch from e5a755d to 43aa8a0 Compare March 25, 2021 18:33
padamstx
padamstx approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 635e364 into main Mar 26, 2021
@padamstx padamstx deleted the add-posture-management branch March 26, 2021 16:00
ibm-devx-automation pushed a commit that referenced this pull request Mar 26, 2021
@semantic-release-bot
chore(release): 0.18.0 release notes [skip ci]
5d805f9 
# [0.18.0](v0.17.20...v0.18.0) (2021-03-26)

### Features

* **Posture Management:** add service to project ([#95](#95)) ([635e364](635e364))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pyrooka @ibm-devx-automation @padamstx