fix(Case Management): re-gen service and add examples #79
Conversation
|
One initial comment... when this PR is squashed and merged, let's use a "fix(Case Management): ..." type commit message so that we end up with a new patch version of the sdk (i.e. 0.17.7 -> 0.17.8). |
| createCaseOptions.SetSeverity(1) | ||
| createCaseOptions.SetEu(&casemanagementv1.CasePayloadEu{Supported: core.BoolPtr(true), DataCenter: core.Int64Ptr(123)}) | ||
|
|
||
| offeringType, _ := caseManagementService.NewOfferingType(casemanagementv1.OfferingTypeGroupCRNServiceNameConst, "cloud-object-storage") |
There was a problem hiding this comment.
I think it would be good to move the construction of the dependent models (offeringType and offeringPayload) to immediately before the construction of the options model. So the general pattern would be to construct dependent models first, then construct the options model and set various fields on it.
pyrooka
changed the title
| BeforeEach(func() { | ||
| shouldSkipTest() | ||
| }) | ||
| It(`GetCases request example`, func() { |
There was a problem hiding this comment.
Let's move this It() block below the one for the update operation... that way the general pattern in terms of order of the examples would be create, get, update, list, delete (there's no delete for this service however).
| "This is an example case description.", | ||
| ) | ||
| createCaseOptions.SetSeverity(1) | ||
| createCaseOptions.SetEu(&casemanagementv1.CasePayloadEu{Supported: core.BoolPtr(true), DataCenter: core.Int64Ptr(123)}) |
There was a problem hiding this comment.
Let's be a little more explicit with the model creation by first constructing an instance of CasePayLoadEu, then calling SetEu() to set it (similar to how the offeringType and offeringPayload objects are constructed above).
| createCaseOptions := caseManagementService.NewCreateCaseOptions( | ||
| "technical", | ||
| "Example technical case", | ||
| "This is an example case description.", |
There was a problem hiding this comment.
| "This is an example case description.", | |
| "This is an example case description. This is where the problem would be described.", |
|
|
||
| statusPayloadModel := &casemanagementv1.ResolvePayload{ | ||
| Action: core.StringPtr("resolve"), | ||
| Comment: core.StringPtr("It was actually a mistake"), |
There was a problem hiding this comment.
| Comment: core.StringPtr("It was actually a mistake"), | |
| Comment: core.StringPtr("The problem has been resolved."), |
|
|
||
| addCommentOptions := caseManagementService.NewAddCommentOptions( | ||
| "CS1234567", | ||
| "This is a test comment", |
There was a problem hiding this comment.
| "This is a test comment", | |
| "This is an example comment", |
| } | ||
|
|
||
| updateCaseStatusOptions := caseManagementService.NewUpdateCaseStatusOptions( | ||
| "CS1234567", |
There was a problem hiding this comment.
Use a variable for this (obtained from the create operation).
| panic(err) | ||
| } | ||
| if result != nil { | ||
| defer result.Close() |
There was a problem hiding this comment.
print contents of file to console (see GC PR for example)
|
|
||
| }) | ||
| It(`RemoveWatchlist request example`, func() { | ||
| // begin-removeWatchlist |
There was a problem hiding this comment.
Move this block under add watchlist example
| addResourceOptions := caseManagementService.NewAddResourceOptions( | ||
| "CS1234567", | ||
| ) | ||
| addResourceOptions.SetNote("This is a test note") |
There was a problem hiding this comment.
set CRN field to crn:mycloud:myservice:123
| addResourceOptions := caseManagementService.NewAddResourceOptions( | ||
| "CS1234567", | ||
| ) | ||
| addResourceOptions.SetNote("This is a test note") |
There was a problem hiding this comment.
| addResourceOptions.SetNote("This is a test note") | |
| addResourceOptions.SetNote("This resource is the service that is having the problem.") |
## [0.17.9](v0.17.8...v0.17.9) (2021-02-18) ### Bug Fixes * **Case Management:** re-gen service and add examples ([#79](#79)) ([0ce3946](0ce3946))
|
🎉 This PR is included in version 0.17.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR summary
This PR adds examples to the Case Management service.
PR Checklist
Please make sure that your PR fulfills the following requirements:
PR Type
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change?
Other information