Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Activity Tracker): re-gen service after recent API changes #69

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

jorge-ibm
Copy link
Contributor

PR summary

This PR contains an update to the Activity Tracker service after recent API changes.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@padamstx
Copy link
Member

@jorge-ibm My usual practice for the platform services is to make sure that the generated code in the SDK is associated with the version of the API definition in the production branch of the cloud-api-docs repo (in the case of atracker, they don't yet have anything in their production branch, so test would suffice until that happens). Let's work to get the changes from Mike's fork merged into the master branch of https://github.ibm.com/cloud-api-docs/atracker before we merge in this PR.

@jorge-ibm jorge-ibm force-pushed the jrangel/regen-atracker branch from 8e32ec9 to cba6384 Compare December 10, 2020 17:44
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorge-ibm
Copy link
Contributor Author

jorge-ibm commented Dec 10, 2020

@yingwang-us can you please re-test the examples/IT and add your review to this? thanks

Edit: I just tested this on the vm we are using for terraform. I've pushed another commit with the needed hand edits to get both the examples/IT passing

@jorge-ibm jorge-ibm force-pushed the jrangel/regen-atracker branch from 0820542 to 1ababff Compare December 10, 2020 22:00
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorge-ibm jorge-ibm force-pushed the jrangel/regen-atracker branch from 1ababff to aef292d Compare December 14, 2020 15:47
@jorge-ibm jorge-ibm merged commit 23cc962 into master Dec 15, 2020
ibm-devx-automation pushed a commit that referenced this pull request Dec 15, 2020
## [0.17.3](v0.17.2...v0.17.3) (2020-12-15)

### Bug Fixes

* **Activity Tracker:** re-gen service after recent API changes ([#69](#69)) ([23cc962](23cc962))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.17.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@christiancompton christiancompton deleted the jrangel/regen-atracker branch February 25, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants