-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Activity Tracker): re-gen service after recent API changes #69
Conversation
@jorge-ibm My usual practice for the platform services is to make sure that the generated code in the SDK is associated with the version of the API definition in the production branch of the cloud-api-docs repo (in the case of atracker, they don't yet have anything in their production branch, so test would suffice until that happens). Let's work to get the changes from Mike's fork merged into the master branch of https://github.ibm.com/cloud-api-docs/atracker before we merge in this PR. |
8e32ec9
to
cba6384
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@yingwang-us can you please re-test the examples/IT and add your review to this? thanks Edit: I just tested this on the vm we are using for terraform. I've pushed another commit with the needed hand edits to get both the examples/IT passing |
0820542
to
1ababff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1ababff
to
aef292d
Compare
## [0.17.3](v0.17.2...v0.17.3) (2020-12-15) ### Bug Fixes * **Activity Tracker:** re-gen service after recent API changes ([#69](#69)) ([23cc962](23cc962))
🎉 This PR is included in version 0.17.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR summary
This PR contains an update to the Activity Tracker service after recent API changes.
PR Checklist
Please make sure that your PR fulfills the following requirements:
PR Type
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change?
Other information