Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Partner Management APIs): add new service to project #360

Merged
merged 16 commits into from
Oct 24, 2024

Conversation

manukm-ibm
Copy link
Member

@manukm-ibm manukm-ibm commented Oct 17, 2024

PR summary

Adding new partner API to fetch resource usage reports.
TRI: https://github.ibm.com/BSS/architecture/blob/master/design-docs/cosell/partner.md
Issue: https://github.ibm.com/BSS/metering-deliverables/issues/2063

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ manukm-ibm
✅ padamstx
❌ semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the README.md (service table) to remove the entries for the two services being removed and add a new entry for the new service that you're adding.
Also, I recommended a change to the package name to shorten it up a bit.

partnermanagementapisv1/partner_management_apis_v1.go Outdated Show resolved Hide resolved
@padamstx padamstx self-assigned this Oct 18, 2024
@manukm-ibm
Copy link
Member Author

manukm-ibm commented Oct 21, 2024

Integration test results
Screenshot 2024-10-21 at 4 20 35 PM

Example run results
Screenshot 2024-10-21 at 4 10 14 PM

manukm-ibm and others added 13 commits October 22, 2024 21:52
## [0.69.2](IBM/platform-services-go-sdk@v0.69.1...v0.69.2) (2024-10-07)

### Bug Fixes

* **Partner Center Sell:** re-gen service after recent API definition changes ([IBM#358](IBM#358)) ([36d86ae](IBM@36d86ae))

Signed-off-by: manu.k.m <[email protected]>
Signed-off-by: Phil Adams <[email protected]>
Signed-off-by: manu.k.m <[email protected]>
## [0.69.3](IBM/platform-services-go-sdk@v0.69.2...v0.69.3) (2024-10-18)

### Bug Fixes

* **build:** bump go core to 5.18.0 ([IBM#359](IBM#359)) ([5d1ad83](IBM@5d1ad83))

Signed-off-by: manu.k.m <[email protected]>
Signed-off-by: manu.k.m <[email protected]>
@manukm-ibm manukm-ibm requested a review from padamstx October 22, 2024 16:28
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit dd6152a into IBM:main Oct 24, 2024
1 of 3 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Oct 24, 2024
# [0.70.0](v0.69.4...v0.70.0) (2024-10-24)

### Features

* **Partner Management APIs:** add new service to project ([#360](#360)) ([dd6152a](dd6152a))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.70.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants