-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Usage Reports): add "created_by_email_id" to Offer schema #355
Conversation
Signed-off-by: Jonathan Date-Chong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jdatechong the builds are finally green, but I just noticed you used an old version of the generator for this PR (released on Apr 10). Could you re-gen your code by using the current latest, please? This applies to your other PRs too, but I'll leave comments just to make sure we won't miss anything. Thanks in advance and sorry for the late notice!
Signed-off-by: Jonathan Date-chong <[email protected]>
@pyrooka SDK has been regenerated with version 3.96.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change, now everything looks good to me!
# [0.71.0](v0.70.0...v0.71.0) (2024-10-28) ### Features * **Usage Reports:** add "created_by_email_id" to Offer schema ([#355](#355)) ([b57da5a](b57da5a))
🎉 This PR is included in version 0.71.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR summary
updated offers to have the CreatedByEmailID field
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
updated offers to have the CreatedByEmailID field
Does this PR introduce a breaking change?
Other information
Test results: