Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Usage Reports): add "created_by_email_id" to Offer schema #355

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

Jdatechong
Copy link
Contributor

PR summary

updated offers to have the CreatedByEmailID field

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

updated offers to have the CreatedByEmailID field

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Test results:

•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 109 of 109 Specs in 3.477 seconds
SUCCESS! -- 109 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/usagereportsv4  5.164s

@pyrooka pyrooka changed the title feat(usage reports): add CreatedByEmailID to Offer feat(Usage Reports): add "created_by_email_id" to Offer schema Sep 10, 2024
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jdatechong the builds are finally green, but I just noticed you used an old version of the generator for this PR (released on Apr 10). Could you re-gen your code by using the current latest, please? This applies to your other PRs too, but I'll leave comments just to make sure we won't miss anything. Thanks in advance and sorry for the late notice!

@Jdatechong Jdatechong requested a review from pyrooka October 18, 2024 17:46
@Jdatechong
Copy link
Contributor Author

@pyrooka SDK has been regenerated with version 3.96.0

Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change, now everything looks good to me!

@pyrooka pyrooka merged commit b57da5a into IBM:main Oct 28, 2024
3 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Oct 28, 2024
# [0.71.0](v0.70.0...v0.71.0) (2024-10-28)

### Features

* **Usage Reports:** add "created_by_email_id" to Offer schema ([#355](#355)) ([b57da5a](b57da5a))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.71.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants