-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Resource Controller): add "onetime_credentials" property in ResourceInstance and ResourceKey schemas #338
Conversation
5b82aa0
to
47982b8
Compare
75b7f76
to
28573d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the requested change, please post the result of the integration and examples test run here. It's required because we need to verify that the SDK continues interacting with the service perfectly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to add these to my previous review. :)
resourcecontrollerv2/resource_controller_v2_integration_test.go
Outdated
Show resolved
Hide resolved
resourcecontrollerv2/resource_controller_v2_integration_test.go
Outdated
Show resolved
Hide resolved
96cf4bd
to
6aae72d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the changes! One more thing: please do not forget to sign the CLA.
61cf3d9
to
cb065f4
Compare
…sts and examples Signed-off-by: arshabbir <[email protected]>
…ourceInstance and ResourceKey schemas Signed-off-by: arshabbir <[email protected]>
cb065f4
to
b7948ea
Compare
# [0.65.0](v0.64.4...v0.65.0) (2024-07-11) ### Features * **Resource Controller:** add "onetime_credentials" property in ResourceInstance and ResourceKey schemas ([#338](#338)) ([44b748d](44b748d))
🎉 This PR is included in version 0.65.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR summary
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information