Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Resource Controller): add "onetime_credentials" property in ResourceInstance and ResourceKey schemas #338

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

arshabbir
Copy link
Contributor

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant
Copy link

CLAassistant commented Jun 21, 2024

CLA assistant check
All committers have signed the CLA.

@arshabbir arshabbir force-pushed the onetime_credentials_parameter branch from 5b82aa0 to 47982b8 Compare June 21, 2024 16:52
@padamstx padamstx changed the title feat(Resource Controller): Added onetime_credentials parameter in ResourceInstance and ResourceKey schemas feat(Resource Controller): add "onetime_credentials" property in ResourceInstance and ResourceKey schemas Jun 26, 2024
@padamstx padamstx requested a review from pyrooka June 26, 2024 22:46
@arshabbir arshabbir force-pushed the onetime_credentials_parameter branch 4 times, most recently from 75b7f76 to 28573d2 Compare July 3, 2024 16:26
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the requested change, please post the result of the integration and examples test run here. It's required because we need to verify that the SDK continues interacting with the service perfectly.

Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to add these to my previous review. :)

@arshabbir arshabbir force-pushed the onetime_credentials_parameter branch 4 times, most recently from 96cf4bd to 6aae72d Compare July 8, 2024 00:52
@arshabbir
Copy link
Contributor Author

Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the changes! One more thing: please do not forget to sign the CLA.

@arshabbir arshabbir force-pushed the onetime_credentials_parameter branch from 61cf3d9 to cb065f4 Compare July 11, 2024 03:49
arshabbir and others added 2 commits July 11, 2024 09:24
@arshabbir arshabbir force-pushed the onetime_credentials_parameter branch from cb065f4 to b7948ea Compare July 11, 2024 03:54
@pyrooka pyrooka merged commit 44b748d into IBM:main Jul 11, 2024
3 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Jul 11, 2024
# [0.65.0](v0.64.4...v0.65.0) (2024-07-11)

### Features

* **Resource Controller:** add "onetime_credentials" property in ResourceInstance and ResourceKey schemas ([#338](#338)) ([44b748d](44b748d))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.65.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants