Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Catalog Management): regen after recent api changes #328

Merged
merged 4 commits into from
May 22, 2024
Merged

feat(Catalog Management): regen after recent api changes #328

merged 4 commits into from
May 22, 2024

Conversation

benbuchanan
Copy link
Contributor

PR summary

regenerating after recent api changes

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

adding new endpoints, removing some deprecated fields

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@padamstx padamstx self-assigned this May 21, 2024
@padamstx padamstx self-requested a review May 21, 2024 16:04
@benbuchanan
Copy link
Contributor Author 

integration
Ran 735 of 791 Specs in 45.839 seconds
SUCCESS! -- 735 Passed | 0 Failed | 0 Pending | 56 Skipped
PASS
ok  	github.com/IBM/platform-services-go-sdk/catalogmanagementv1	46.832s

example
Ran 723 of 753 Specs in 45.915 seconds
SUCCESS! -- 723 Passed | 0 Failed | 0 Pending | 30 Skipped
PASS
ok  	github.com/IBM/platform-services-go-sdk/catalogmanagementv1	46.958s

padamstx
padamstx approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

padamstx
padamstx requested changes May 21, 2024
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved too quickly before :)
The examples code needs a couple of small changes.

padamstx
padamstx approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 6f4dee7 into IBM:main May 22, 2024
3 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request May 22, 2024
@semantic-release-bot
chore(release): 0.63.0 release notes [skip ci]
6a88f9a 
# [0.63.0](v0.62.11...v0.63.0) (2024-05-22)

### Features

* **Catalog Management:** regen after recent api changes ([#328](#328)) ([6f4dee7](6f4dee7))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.63.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benbuchanan @ibm-devx-sdk @padamstx