feat(Catalog Management): support change notices and plan id in offer… #325
Conversation
…ing instance create Signed-off-by: Ben Buchanan <[email protected]>
|
|
Signed-off-by: Ben Buchanan <[email protected]>
There was a problem hiding this comment.
- Need to re-gen with the latest version of the SDK generator in order to leverage the new support for error handling in the Go SDK and Terraform providers.
- Need to add working examples code and integration tests for the GetPlan, DeletePlan, ConsumablePlan, and SetDeprecatePlan operations.
| @@ -377,6 +377,31 @@ var _ = Describe(`CatalogManagementV1 Examples Tests`, func() { | |||
| offeringID = *offering.ID | |||
| }) | |||
|
|
|||
| It(`GetOfferingChangeNotices request example`, func() { | |||
There was a problem hiding this comment.
There are no examples for the get_plan, delete_plan, consumable_plan or set_deprecate_plan operations.
| @@ -610,6 +610,12 @@ var _ = Describe(`CatalogManagementV1 Integration Tests`, func() { | |||
| Evaluations: []catalogmanagementv1.Evaluation{*evaluationModel}, | |||
There was a problem hiding this comment.
No integration tests for the get_plan, delete_plan, consumable_plan, set_deprecate_plan operations.
|
@padamstx Our API does not have the ability to create a plan unless the token making the call is an approver (Plans are created in Partner Center and they call us with an approver token to create them). We just provide another way to manage them with the delete, deprecate, publish. Is there precedence for running tests with a different token? |
Yes, I think the enterprise management integration tests might do that. Essentially, you'd need to manually change the integration test code so that you create two different instances of the service client, and for each one you'd use a different instance of the IAM authenticator that is configured with the appropriate apikey. Then you'd need to use the correct instance of the service client when invoking operations. |
Signed-off-by: Ben Buchanan <[email protected]>
|
example tests: integration tests: |
## [0.62.11](v0.62.10...v0.62.11) (2024-05-03) ### Bug Fixes * **Catalog Management:** support change notices and plan id in offering instance create ([#325](#325)) ([66e14c5](66e14c5))
|
🎉 This PR is included in version 0.62.11 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
…ing instance create
PR summary
Need these changes to update the catalog management terraform provider.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Just adding new fields that our api now supports. Needed to update our terraform provider.
Does this PR introduce a breaking change?
Other information