Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Usage Reports): re-gen service after recent API changes #320

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

Jdatechong
Copy link
Contributor

PR summary

Regeneration of the usage reports service. Mainly intended to add catalog_id to instance_usage and resource.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Test results:

Running Suite: UsageReportsV4 Suite
===================================
Random Seed: 1712872455
Will run 109 of 109 specs

•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 109 of 109 Specs in 3.467 seconds
SUCCESS! -- 109 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/usagereportsv4  3.842s

Integration tests:

Running Suite: UsageReportsV4 Suite
===================================
Random Seed: 1712794296
Will run 120 of 120 specs

••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 120 of 120 Specs in 16.652 seconds
SUCCESS! -- 120 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/usagereportsv4  16.979s

Examples:

Ran 124 of 124 Specs in 19.398 seconds
SUCCESS! -- 124 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/usagereportsv4  20.178s

@CLAassistant
Copy link

CLAassistant commented Apr 11, 2024

CLA assistant check
All committers have signed the CLA.

@padamstx padamstx self-assigned this Apr 12, 2024
@padamstx padamstx self-requested a review April 12, 2024 20:53
@padamstx padamstx changed the title feat(Usage Reports) re-gen service after recent API changes fix(Usage Reports): re-gen service after recent API changes Apr 13, 2024
@padamstx
Copy link
Member

@Jdatechong it looks like you used a fairly old version of the SDK generator (3.75.0) to regen this service. Please install the latest version of the generator (currently 3.89.0) and regen with that.

@padamstx
Copy link
Member

@Jdatechong just wanted to double-check that you saw my comment above about needing to re-gen the go and java sdk code with a recent version of the SDK generator. I've merged the node and python PRs so as of right now, your service is not in sync between go/java vs node/python.

@Jdatechong
Copy link
Contributor Author

@padamstx the go and java sdks have been regenerated with a newer version of the sdk generator

test results after update:

Running Suite: UsageReportsV4 Suite
===================================
Random Seed: 1713384902
Will run 103 of 103 specs

•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 103 of 103 Specs in 3.166 seconds
SUCCESS! -- 103 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/usagereportsv4  3.532s

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit aad1c24 into IBM:main Apr 18, 2024
3 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Apr 18, 2024
## [0.62.6](v0.62.5...v0.62.6) (2024-04-18)

### Bug Fixes

* **Usage Reports:** re-gen service after recent API changes ([#320](#320)) ([aad1c24](aad1c24))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.62.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants