Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Catalog Management): re-gen service after recent API changes #298

Merged
merged 6 commits into from
Feb 13, 2024
Merged

feat(Catalog Management): re-gen service after recent API changes #298

merged 6 commits into from
Feb 13, 2024

Conversation

benbuchanan
Copy link
Contributor

PR summary

Re-generating Go SDK after API updates

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

New features associated with API updates

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@benbuchanan benbuchanan requested a review from padamstx February 6, 2024 14:45
@padamstx padamstx self-assigned this Feb 12, 2024
@benbuchanan
Copy link
Contributor Author

Examples tests:

Ran 599 of 627 Specs in 37.819 seconds
SUCCESS! -- 599 Passed | 0 Failed | 0 Pending | 28 Skipped
PASS
ok  	github.com/IBM/platform-services-go-sdk/catalogmanagementv1	38.914s

Integration tests:

Ran 610 of 666 Specs in 38.160 seconds
SUCCESS! -- 610 Passed | 0 Failed | 0 Pending | 56 Skipped
PASS
ok  	github.com/IBM/platform-services-go-sdk/catalogmanagementv1	38.933s

padamstx
padamstx reviewed Feb 13, 2024
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that there's no example code block for the GetOfferingSourceArchive operation. But otherwise, this looks good.

catalogmanagementv1/catalog_management_v1_examples_test.go Show resolved Hide resolved
padamstx
padamstx approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit f7f8acc into IBM:main Feb 13, 2024
3 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Feb 13, 2024
@semantic-release-bot
chore(release): 0.57.0 release notes [skip ci]
300d4b6 
# [0.57.0](v0.56.4...v0.57.0) (2024-02-13)

### Features

* **Catalog Management:** re-gen service after recent API changes ([#298](#298)) ([f7f8acc](f7f8acc))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.57.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benbuchanan @ibm-devx-sdk @padamstx