Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ATracker): add eu-es region changes and remove migration code #281

Merged
merged 5 commits into from
Sep 27, 2023
Merged

fix(ATracker): add eu-es region changes and remove migration code #281

merged 5 commits into from
Sep 27, 2023

Conversation

adya1303
Copy link
Contributor

@adya1303 adya1303 commented Sep 25, 2023 •
edited
Loading

PR summary

Added endpoint details for newly added Madrid region and removed migration code for v1 to v2.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Code for migrating atracker from v1 to v2 is removed. Also new endpoint details for Madrid region is added.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@adya1303 adya1303 changed the title fix (metrics router) Added eu-es region changes and removed migration code fix (metrics router): Added eu-es region changes and removed migration code Sep 25, 2023
@padamstx padamstx self-assigned this Sep 25, 2023
@padamstx padamstx changed the title fix (metrics router): Added eu-es region changes and removed migration code fix(metrics router): add eu-es region changes and remove migration code Sep 25, 2023
@padamstx padamstx self-requested a review September 25, 2023 14:27
@padamstx padamstx mentioned this pull request Sep 25, 2023
Merged
5 tasks
@adya1303 adya1303 changed the title fix(metrics router): add eu-es region changes and remove migration code fix(atracker): add eu-es region changes and remove migration code Sep 25, 2023
@adya1303 adya1303 marked this pull request as draft September 25, 2023 14:32
@adya1303
Copy link
Contributor Author

Ran integration test -
image

@adya1303 adya1303 marked this pull request as ready for review September 26, 2023 03:47
@padamstx padamstx changed the title fix(atracker): add eu-es region changes and remove migration code fix(ATracker): add eu-es region changes and remove migration code Sep 27, 2023
padamstx
padamstx approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 3dd6978 into IBM:main Sep 27, 2023
2 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Sep 27, 2023
@semantic-release-bot
chore(release): 0.50.4 release notes [skip ci]
bf82424 
## [0.50.4](v0.50.3...v0.50.4) (2023-09-27)

### Bug Fixes

* **ATracker:** add eu-es region, remove migration code ([#281](#281)) ([3dd6978](3dd6978))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.50.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adya1303 @ibm-devx-sdk @padamstx