Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Context-Based Restrictions): fix output to Operations #278

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

JonahFarc
Copy link
Contributor

PR summary

Add on to previous work:
#277

The output is improper due to generation from an older version of the swagger. The change should be very minor and will be propagated to the other languages' PRs.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Adds the "Type" output

Does this PR introduce a breaking change?

  • Yes
  • No

@JonahFarc
Copy link
Contributor Author

Test screenshots:
image
Uploading image.png…

@JonahFarc
Copy link
Contributor Author

Waiting on a review from someone on my side as well

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@soohoowoohoo soohoowoohoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@JonahFarc
Copy link
Contributor Author

Test Screenshot:
image
Examples Screenshot:
image

@JonahFarc
Copy link
Contributor Author

@padamstx should be good to merge whenever you're ready!

@padamstx padamstx self-assigned this Sep 15, 2023
@padamstx padamstx merged commit 424b6b5 into IBM:main Sep 15, 2023
ibm-devx-sdk pushed a commit that referenced this pull request Sep 15, 2023
## [0.50.1](v0.50.0...v0.50.1) (2023-09-15)

### Bug Fixes

* **Context-Based Restrictions:** fix output to Operations ([#278](#278)) ([424b6b5](424b6b5))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.50.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@JonahFarc JonahFarc deleted the cbr-fix branch September 15, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants