-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Usage Reports): add billing snapshot config service to usage reports #272
Conversation
|
21ded7e
to
933f735
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few questions/issues to be addressed:
- Did you really intend to completely overwrite the previous version of the integration tests? There was manually developed code there that probably should be retained. Please see https://github.com/IBM/platform-services-go-sdk/blob/main/update_service.md#updating-integration-testsexamples for instructions on how to update the integration tests and examples code while still retaining the previous manual changes.
- There were no changes to the examples code, but yet the updates to the generated service code show 5 new operations.
- It looks like a handful of timestamp-related properties that are supposed to hold "millisecond" values were defined in the API definition as "type number", which results in a language-specific floating point type being used in the generated code. Are you sure that the server behavior supports a floating point value for these properties? I would expect the API definition to use "type integer" and for the fields to be defined with a language-specific integer type.
1c437e2
to
b68d7a7
Compare
@manukm-ibm I took a fresh look at the changes and it looks like 6 operations have been added to the API (based on the changes to the generated service code):
We'll need integration tests and working examples for each of those new operations. It might help to generate the int tests and examples off to the side (i.e. into a different output directory), then copy/paste individual sections for each new operation into the checked-in version of the int tests and examples. |
Signed-off-by: Norbert Biczo <[email protected]> Signed-off-by: manu.k.m <[email protected]>
Signed-off-by: manu.k.m <[email protected]>
# [0.46.0](IBM/platform-services-go-sdk@v0.45.0...v0.46.0) (2023-08-18) ### Features * bump Go versions ([IBM#271](IBM#271)) ([d5e0092](IBM@d5e0092)) Signed-off-by: manu.k.m <[email protected]>
…orts Signed-off-by: manu.k.m <[email protected]>
IBM#274) Signed-off-by: Rajesh K Pirati <[email protected]> Signed-off-by: manu.k.m <[email protected]>
Signed-off-by: manu.k.m <[email protected]>
# [0.47.0](IBM/platform-services-go-sdk@v0.46.0...v0.47.0) (2023-08-28) ### Features * **IAM Policy Management:** fix template metadata as part of policies ([IBM#274](IBM#274)) ([542046f](IBM@542046f)) Signed-off-by: manu.k.m <[email protected]>
Signed-off-by: manu.k.m <[email protected]>
Signed-off-by: manu.k.m <[email protected]>
This commit updates the project to enable builds to be performed on Windows. I also bumped the go core version to the current latest. Signed-off-by: Phil Adams <[email protected]> Signed-off-by: manu.k.m <[email protected]>
Signed-off-by: manu.k.m <[email protected]>
## [0.47.1](IBM/platform-services-go-sdk@v0.47.0...v0.47.1) (2023-08-31) ### Bug Fixes * enable builds on windows ([IBM#273](IBM#273)) ([b39d2d5](IBM@b39d2d5)) Signed-off-by: manu.k.m <[email protected]>
…lamations (IBM#264) Co-authored-by: Phil Adams <[email protected]> Signed-off-by: manu.k.m <[email protected]>
Signed-off-by: manu.k.m <[email protected]>
Signed-off-by: manu.k.m <[email protected]>
…napshot config service Signed-off-by: manu.k.m <[email protected]>
Signed-off-by: manu.k.m <[email protected]>
# [0.48.0](IBM/platform-services-go-sdk@v0.47.1...v0.48.0) (2023-09-01) ### Features * **Resource Controller:** support resource group filter for list reclamations ([IBM#264](IBM#264)) ([6985653](IBM@6985653)) Signed-off-by: manu.k.m <[email protected]>
…IBM#276) Signed-off-by: HARI K ARLA <[email protected]> Signed-off-by: manu.k.m <[email protected]>
Signed-off-by: manu.k.m <[email protected]>
## [0.48.1](IBM/platform-services-go-sdk@v0.48.0...v0.48.1) (2023-09-05) ### Bug Fixes * **IAM Access Groups:** rRemove update action control from assertions ([IBM#276](IBM#276)) ([75ec5ee](IBM@75ec5ee)) Signed-off-by: manu.k.m <[email protected]>
…ions (IBM#277) Signed-off-by: Dylan <[email protected]> Signed-off-by: manu.k.m <[email protected]>
Signed-off-by: manu.k.m <[email protected]>
# [0.49.0](IBM/platform-services-go-sdk@v0.48.1...v0.49.0) (2023-09-13) ### Features * **Context-Based Restrictions:** add service group support to operations ([IBM#277](IBM#277)) ([8ecdfa5](IBM@8ecdfa5)) Signed-off-by: manu.k.m <[email protected]>
fcab151
to
37704ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I had just one minor suggested change in the integration tests.
@manukm-ibm For some reason, it looks like this PR contains 28 commits, but most of those are commits that already were merged into main, so this looks pretty strange :) Could you perhaps rebase your feature branch on the current main branch from the primary repo and clear that up? |
Signed-off-by: manu.k.m <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# [0.50.0](v0.49.0...v0.50.0) (2023-09-14) ### Features * **Usage Reports:** add billing snapshot config service to usage reports ([#272](#272)) ([c56989e](c56989e))
🎉 This PR is included in version 0.50.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR summary
Introducing new CRUD APIs to configure billing reports snapshot.
TRI: https://github.ibm.com/BSS/architecture/blob/master/design-docs/services/billing/apptio-integration.md
Issue: https://github.ibm.com/BSS/metering-deliverables/issues/1990
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information