Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Usage Reports): add billing snapshot config service to usage reports #272

Merged
merged 29 commits into from
Sep 14, 2023

Conversation

manukm-ibm
Copy link
Member

@manukm-ibm manukm-ibm commented Aug 21, 2023

PR summary

Introducing new CRUD APIs to configure billing reports snapshot.
TRI: https://github.ibm.com/BSS/architecture/blob/master/design-docs/services/billing/apptio-integration.md
Issue: https://github.ibm.com/BSS/metering-deliverables/issues/1990

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant
Copy link

CLAassistant commented Aug 21, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
7 out of 8 committers have signed the CLA.

✅ pyrooka
✅ manukm-ibm
✅ hariarla
✅ padamstx
✅ apoorva9s14
✅ JonahFarc
✅ Rajesh-Pirati
❌ semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

@padamstx padamstx self-assigned this Aug 21, 2023
@padamstx padamstx self-requested a review August 21, 2023 18:40
@padamstx padamstx changed the title feat(Usage Reports): add billing snapshot config service to usage rep… feat(Usage Reports): add billing snapshot config service to usage reports Aug 21, 2023
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few questions/issues to be addressed:

  1. Did you really intend to completely overwrite the previous version of the integration tests? There was manually developed code there that probably should be retained. Please see https://github.com/IBM/platform-services-go-sdk/blob/main/update_service.md#updating-integration-testsexamples for instructions on how to update the integration tests and examples code while still retaining the previous manual changes.
  2. There were no changes to the examples code, but yet the updates to the generated service code show 5 new operations.
  3. It looks like a handful of timestamp-related properties that are supposed to hold "millisecond" values were defined in the API definition as "type number", which results in a language-specific floating point type being used in the generated code. Are you sure that the server behavior supports a floating point value for these properties? I would expect the API definition to use "type integer" and for the fields to be defined with a language-specific integer type.

usagereportsv4/usage_reports_v4.go Outdated Show resolved Hide resolved
usagereportsv4/usage_reports_v4.go Outdated Show resolved Hide resolved
usagereportsv4/usage_reports_v4.go Outdated Show resolved Hide resolved
usagereportsv4/usage_reports_v4_integration_test.go Outdated Show resolved Hide resolved
@manukm-ibm manukm-ibm force-pushed the bill-snapshot branch 2 times, most recently from 1c437e2 to b68d7a7 Compare August 24, 2023 16:42
@padamstx
Copy link
Member

@manukm-ibm I took a fresh look at the changes and it looks like 6 operations have been added to the API (based on the changes to the generated service code):

  • CreateReportsSnapshotConfig
  • GetReportsSnapshotConfig
  • UpdateReportsSnapshotConfig
  • DeleteReportsSnapshotConfig
  • GetReportsSnapshot

We'll need integration tests and working examples for each of those new operations. It might help to generate the int tests and examples off to the side (i.e. into a different output directory), then copy/paste individual sections for each new operation into the checked-in version of the int tests and examples.
Reference: https://github.com/IBM/platform-services-go-sdk/blob/main/update_service.md#updating-integration-testsexamples

go.mod Outdated Show resolved Hide resolved
pyrooka and others added 20 commits September 13, 2023 21:12
Signed-off-by: Norbert Biczo <[email protected]>
Signed-off-by: manu.k.m <[email protected]>
# [0.46.0](IBM/platform-services-go-sdk@v0.45.0...v0.46.0) (2023-08-18)

### Features

* bump Go versions ([IBM#271](IBM#271)) ([d5e0092](IBM@d5e0092))

Signed-off-by: manu.k.m <[email protected]>
# [0.47.0](IBM/platform-services-go-sdk@v0.46.0...v0.47.0) (2023-08-28)

### Features

* **IAM Policy Management:** fix  template metadata as part of policies ([IBM#274](IBM#274)) ([542046f](IBM@542046f))

Signed-off-by: manu.k.m <[email protected]>
This commit updates the project to enable
builds to be performed on Windows.
I also bumped the go core version to the current latest.

Signed-off-by: Phil Adams <[email protected]>
Signed-off-by: manu.k.m <[email protected]>
## [0.47.1](IBM/platform-services-go-sdk@v0.47.0...v0.47.1) (2023-08-31)

### Bug Fixes

* enable builds on windows ([IBM#273](IBM#273)) ([b39d2d5](IBM@b39d2d5))

Signed-off-by: manu.k.m <[email protected]>
Signed-off-by: manu.k.m <[email protected]>
# [0.48.0](IBM/platform-services-go-sdk@v0.47.1...v0.48.0) (2023-09-01)

### Features

* **Resource Controller:** support resource group filter for list reclamations ([IBM#264](IBM#264)) ([6985653](IBM@6985653))

Signed-off-by: manu.k.m <[email protected]>
## [0.48.1](IBM/platform-services-go-sdk@v0.48.0...v0.48.1) (2023-09-05)

### Bug Fixes

* **IAM Access Groups:** rRemove update action control from assertions ([IBM#276](IBM#276)) ([75ec5ee](IBM@75ec5ee))

Signed-off-by: manu.k.m <[email protected]>
# [0.49.0](IBM/platform-services-go-sdk@v0.48.1...v0.49.0) (2023-09-13)

### Features

* **Context-Based Restrictions:** add service group support to operations ([IBM#277](IBM#277)) ([8ecdfa5](IBM@8ecdfa5))

Signed-off-by: manu.k.m <[email protected]>
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I had just one minor suggested change in the integration tests.

usagereportsv4/usage_reports_v4_integration_test.go Outdated Show resolved Hide resolved
@padamstx
Copy link
Member

@manukm-ibm For some reason, it looks like this PR contains 28 commits, but most of those are commits that already were merged into main, so this looks pretty strange :) Could you perhaps rebase your feature branch on the current main branch from the primary repo and clear that up?

@manukm-ibm
Copy link
Member Author

Integration test results of new changes
Screenshot 2023-09-14 at 11 59 49 AM

Examples results of new changes
Screenshot 2023-09-14 at 12 44 16 PM

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit c56989e into IBM:main Sep 14, 2023
ibm-devx-sdk pushed a commit that referenced this pull request Sep 14, 2023
# [0.50.0](v0.49.0...v0.50.0) (2023-09-14)

### Features

* **Usage Reports:** add billing snapshot config service to usage reports ([#272](#272)) ([c56989e](c56989e))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.50.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants