feat (IAM Access Groups): Add support for access group templates #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariarla
force-pushed
the
enable_ag_template_operations_gosdk
branch
2 times, most recently
from
45c5ec8 to
5fddbe7
Compare
|
Tests: Integration Tests: **Example Tests: |
pyrooka
requested changes
Jul 27, 2023
Comment on lines
29
to
30
| . "github.com/onsi/ginkgo" | ||
| . "github.com/onsi/gomega" |
There was a problem hiding this comment.
Why these have been removed? As you can see the builds failed due these missing dependencies.
hariarla
force-pushed
the
enable_ag_template_operations_gosdk
branch
from
5fddbe7 to
7c0e2d0
Compare
|
Basic Tests: Integration Tests: |
padamstx
approved these changes
Aug 7, 2023
|
|
||
| getTemplateVersionOptions := iamAccessGroupsService.NewGetTemplateVersionOptions( | ||
| testTemplateId, | ||
| "2", |
There was a problem hiding this comment.
In terms of this being an example for users to follow, would it be better to use a variable here that is simply assigned the value "2"
Suggested change
| "2", | |
| testTemplateVersion, |
| }) | ||
| It(`GetTemplateVersion request example 2`, func() { | ||
| fmt.Println("\nGetTemplateVersion() result:") | ||
| // begin-get_template_version |
There was a problem hiding this comment.
You cannot have >1 request example per operation.
padamstx
force-pushed
the
enable_ag_template_operations_gosdk
branch
from
9b2e4e1 to
7c0e2d0
Compare
hariarla
force-pushed
the
enable_ag_template_operations_gosdk
branch
from
6443f63 to
2d7dcb5
Compare
Signed-off-by: HARI K ARLA <[email protected]>
hariarla
force-pushed
the
enable_ag_template_operations_gosdk
branch
from
2d7dcb5 to
fdb85ee
Compare
|
Unit Tests: Integration Tests: Example Tests: |
padamstx
pushed a commit
that referenced
this pull request
Aug 12, 2023
Signed-off-by: HARI K ARLA <[email protected]>
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Aug 12, 2023
# [0.44.0](v0.43.0...v0.44.0) (2023-08-12) ### Features * **IAM Access Groups:** add support for access group templates ([#266](#266)) ([afe6400](afe6400))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
SDK adopters will be able to call access group template and assignment APIs.
Does this PR introduce a breaking change?
Other information
API Definition
Stage
Production
Tests:
Example Tests:
Integration Tests: