Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Enterprise Management): re-gen service after adding enterprise_iam_managed in traits #263

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

namratabhadauriya
Copy link
Contributor

@namratabhadauriya namratabhadauriya commented Jul 3, 2023

PR summary

re-gen service after adding enterprise_iam_managed field in traits object

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant
Copy link

CLAassistant commented Jul 3, 2023

CLA assistant check
All committers have signed the CLA.

@namratabhadauriya namratabhadauriya force-pushed the update-enterprise-management branch from 283b597 to 832c8c2 Compare July 3, 2023 17:57
@padamstx padamstx self-assigned this Jul 5, 2023
@padamstx padamstx self-requested a review July 5, 2023 13:36
@padamstx
Copy link
Member

padamstx commented Jul 5, 2023

@namratabhadauriya It looks like your PR failed the "signed-off-by" check. To fix this, please amend your commit and add the "-s" (signed off by) option, then force-push to remote. Please do this for the other PRs that also failed the "DCO" check. For more details, please see the "update_service.md" file in each SDK project.

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than the "signed off by" issue.

@namratabhadauriya namratabhadauriya force-pushed the update-enterprise-management branch from 52dc5f0 to 0a74cae Compare July 5, 2023 15:39
@padamstx padamstx merged commit 52cfdaf into main Jul 5, 2023
@padamstx padamstx deleted the update-enterprise-management branch July 5, 2023 17:35
ibm-devx-sdk pushed a commit that referenced this pull request Jul 14, 2023
# [0.41.0](v0.40.0...v0.41.0) (2023-07-14)

### Features

* **Enterprise Management:** re-gen service after update trait object ([#263](#263)) ([52cfdaf](52cfdaf))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.41.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants