Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Global Search): remove is_hidden param from search operation #239

Merged
merged 1 commit into from
Mar 7, 2023
Merged

fix(Global Search): remove is_hidden param from search operation #239

merged 1 commit into from
Mar 7, 2023

Conversation

francescadecicco
Copy link
Contributor

@francescadecicco francescadecicco commented Mar 3, 2023 •
edited by padamstx
Loading

PR summary

removed an internal search parameter: is_hidden

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@padamstx
Copy link
Member

padamstx commented Mar 6, 2023 •
edited by francescadecicco
Loading

In the PR description, you mentioned both Search and Tagging services, but you only updated the files for Search. Do you also plan on re-generating the Tagging service also?

No Phil, only search apis are changed

padamstx
padamstx approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx changed the title fix(Global Search/Tagging): regenerated services with latest API defi… fix(Global Search): re-gen service with latest API definition Mar 7, 2023
@padamstx
Copy link
Member

padamstx commented Mar 7, 2023

Following the Integration Tests results:

Screenshot 2023-03-03 at 16 27 10

@padamstx padamstx changed the title fix(Global Search): re-gen service with latest API definition fix(Global Search): remove is_hidden param from search operation Mar 7, 2023
@padamstx padamstx merged commit 67937e4 into main Mar 7, 2023
@padamstx padamstx deleted the global_search_2 branch March 7, 2023 18:21
ibm-devx-sdk pushed a commit that referenced this pull request Mar 7, 2023
@semantic-release-bot
chore(release): 0.32.2 release notes [skip ci]
c41684a 
## [0.32.2](v0.32.1...v0.32.2) (2023-03-07)

### Bug Fixes

* **Global Search:** remove is_hidden param from search operation ([#239](#239)) ([67937e4](67937e4))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.32.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@francescadecicco @CLAassistant @padamstx @ibm-devx-sdk