Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EnterpriseManagementv1): re-gen service after recent API changes #237

Merged
merged 8 commits into from
Apr 21, 2023

Conversation

namratabhadauriya
Copy link
Contributor

@namratabhadauriya namratabhadauriya commented Feb 28, 2023

PR summary

Added two new operations in enterprise management APIs. The operations are DeleteAccount and DeleteAccountGroup.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant
Copy link

CLAassistant commented Feb 28, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ namratabhadauriya
✅ padamstx
❌ namrata


namrata seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@padamstx padamstx self-requested a review February 28, 2023 14:55
@padamstx padamstx self-assigned this Mar 15, 2023
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Please post screenshots showing a clean test run for the examples and int tests:

cd enterprisemanagementv1
go test -tags=integration
go test -tags=examples

@namratabhadauriya
Copy link
Contributor Author

namratabhadauriya commented Apr 21, 2023

Unit Test -

image

Integration Test -

image

Example code result -
image

@padamstx padamstx merged commit 5efc6b6 into IBM:main Apr 21, 2023
ibm-devx-sdk pushed a commit that referenced this pull request Apr 21, 2023
# [0.36.0](v0.35.1...v0.36.0) (2023-04-21)

### Features

* **EnterpriseManagementv1:** re-gen service after recent API changes ([#237](#237)) ([5efc6b6](5efc6b6))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.36.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants