Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IAM Policy Management): v2/policies updates for time-based condition and tags #231

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

swcolley
Copy link
Contributor

@swcolley swcolley commented Jan 24, 2023

PR summary

Updated time-based condition example and pattern, update property names based on API definition changes, and add support for tags

Issue: https://github.ibm.com/IAM/AM-issues/issues/1079

PR Checklist

Please make sure that your PR fulfills the following requirements:

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Based on API handbook, operation IDs were updated and this effected type and struct names of existing code (e.g., UpdateRole --> ReplaceRole, since it is a post operation).

…attern,

update property names based on API definition changes,
and add support for tags

Signed-off-by: Shaun Colley <[email protected]>
@padamstx padamstx self-requested a review January 24, 2023 21:19
@padamstx padamstx self-assigned this Jan 24, 2023
@swcolley swcolley changed the title fix(IAM Policy Management): v2/policies updates fix(IAM Policy Management): v2/policies updates for time-based condition and tags Jan 24, 2023
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 92d5126 into main Jan 25, 2023
@padamstx padamstx deleted the timeBaseConditionWeekly branch January 25, 2023 20:48
ibm-devx-sdk pushed a commit that referenced this pull request Jan 25, 2023
## [0.31.4](v0.31.3...v0.31.4) (2023-01-25)

### Bug Fixes

* **IAM Policy Management:** update time-based condition example and pattern, ([#231](#231)) ([92d5126](92d5126))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.31.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Jdatechong pushed a commit to Jdatechong/platform-services-go-sdk that referenced this pull request Feb 2, 2023
…attern, (IBM#231)

update property names based on API definition changes,
and add support for tags

Signed-off-by: Shaun Colley <[email protected]>
Signed-off-by: Jonathan Date-chong <[email protected]>
Jdatechong pushed a commit to Jdatechong/platform-services-go-sdk that referenced this pull request Feb 2, 2023
## [0.31.4](IBM/platform-services-go-sdk@v0.31.3...v0.31.4) (2023-01-25)

### Bug Fixes

* **IAM Policy Management:** update time-based condition example and pattern, ([IBM#231](IBM#231)) ([92d5126](IBM@92d5126))

Signed-off-by: Jonathan Date-chong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants