-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Enterprise Billing Units): add start and limit parameters to billing unit APIs #230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done a quick preliminary review of the PR and what you've done so far looks good, but we also would need the examples and integration tests to be updated to reflect the use of the new Pager structs.
Especially the examples since we want to encourage users to use the Pagers. The Enterprise Usage Reports service might be a good one to use as a model for updating the examples and int tests.
…ling unit APIs Signed-off-by: Jonathan Date-chong <[email protected]>
Signed-off-by: Jonathan Date-chong <[email protected]>
Signed-off-by: Jonathan Date-chong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
please paste a screenshot of a successful run of the integration tests and examples:
cd enterprisebillingunitsv1
go test -tags=integration
go test -tags=examples
@Jdatechong Looks like the build for this PR also had lint errors. You can run |
Signed-off-by: Jonathan Date-chong <[email protected]>
Results from
Results from
|
My guess is that the 10 int tests and 6 examples that were skipped are due to a missing config file for your service (i.e. enterprise_billing_units.env). You can find this in the examples file:
Edit: when you run the int tests or examples, you can use the -ginkgo.v option and you'll get more detail printed to ensure that you really are running the tests (or examples). |
Signed-off-by: Jonathan Date-chong <[email protected]>
Signed-off-by: Jonathan Date-chong <[email protected]>
Results from the integration tests:
Results from the examples:
|
# [0.35.0](v0.34.0...v0.35.0) (2023-03-29) ### Features * **Enterprise Billing Units:** add start and limit parameters to billing unit list APIs ([#230](#230)) ([19296ca](19296ca))
🎉 This PR is included in version 0.35.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR summary
Adds start and limit parameters to support pagination for certain Enterprise Billing Units APIs
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Results can now be optionally paginated using the start and limit parameters.
Does this PR introduce a breaking change?
Test results