feat(Metrics Router): add new Metrics Router service to project #225

adya1303 · 2022-12-13T15:01:46Z

PR summary

This PR adds the Metrics Router service to the project, including integration tests and request examples.

PR Checklist

Please make sure that your PR fulfills the following requirements:

The commit message follows the Angular Commit Message Guidelines.
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR introduce a breaking change?

Yes
No

Other information

Signed-off-by: ADYA NAND JHA <[email protected]>

adya1303 · 2022-12-14T05:08:06Z

unit tests

~/Documents/GO/src/github.com/IBM/platform-services-go-sdk/metricsrouterv3 (add-mr-12132022) $ go test
Running Suite: MetricsRouterV3 Suite
====================================
Random Seed: 1670477696
Will run 91 of 91 specs

•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 91 of 91 Specs in 6.766 seconds
SUCCESS! -- 91 Passed | 0 Failed | 0 Pending | 0 Skipped

integration tests

~/Documents/GO/src/github.com/IBM/platform-services-go-sdk/metricsrouterv3 (add-mr-12132022) $ go test -tags="integration" -v
=== RUN   TestMetricsRouterV3
Running Suite: MetricsRouterV3 Suite
====================================
Random Seed: 1670478288
Will run 135 of 135 specs

•••••••••••••
------------------------------
• [SLOW TEST:5.289 seconds]
MetricsRouterV3 Integration Tests
/Users/adyanandjha/Documents/GO/src/github.com/IBM/platform-services-go-sdk/metricsrouterv3/metrics_router_v3_integration_test.go:42
  ListTargets - List targets
  /Users/adyanandjha/Documents/GO/src/github.com/IBM/platform-services-go-sdk/metricsrouterv3/metrics_router_v3_integration_test.go:392
    ListTargets(listTargetsOptions *ListTargetsOptions)
    /Users/adyanandjha/Documents/GO/src/github.com/IBM/platform-services-go-sdk/metricsrouterv3/metrics_router_v3_integration_test.go:397
------------------------------
•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 135 of 135 Specs in 28.251 seconds
SUCCESS! -- 135 Passed | 0 Failed | 0 Pending | 0 Skipped

example tests

~/Documents/GO/src/github.com/IBM/platform-services-go-sdk/metricsrouterv3 (add-mr-12132022) $ go test -tags="examples" -v
=== RUN   TestMetricsRouterV3
Running Suite: MetricsRouterV3 Suite
====================================
Random Seed: 1670478421
Will run 106 of 106 specs

•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 106 of 106 Specs in 11.220 seconds
SUCCESS! -- 106 Passed | 0 Failed | 0 Pending | 0 Skipped

padamstx · 2022-12-19T17:45:54Z

@adya1303 In preparation for a formal SF review of the SDK work in early January, could you please update your branch with the latest changes from "main", and when you are already for a review please click the "Ready for review" button on your draft PR. Thanks!

adya1303 · 2022-12-21T05:12:37Z

@adya1303 In preparation for a formal SF review of the SDK work in early January, could you please update your branch with the latest changes from "main", and when you are already for a review please click the "Ready for review" button on your draft PR. Thanks!

sure @padamstx

adya1303 · 2023-01-03T03:56:55Z

@padamstx Can you please review the PR. Thanks

padamstx

LGTM, just need to verify that the sydney region is the correct default endpoint URL (see my separate comment on that).

metricsrouterv3/metrics_router_v3.go

padamstx · 2023-01-04T20:34:10Z

I've approved the PR and I will merge when it is the appropriate time to do so. This would be at about the same time as the service implementation is made available in the production environment. Just let me know when and I will merge.

padamstx · 2023-01-11T16:11:15Z

@adya1303 Could you please update your branch with the latest changes from "main"?
Also, please address my question about the default endpoint URL above. Thanks.

adya1303 · 2023-01-17T10:19:57Z

@adya1303 Could you please update your branch with the latest changes from "main"? Also, please address my question about the default endpoint URL above. Thanks.

Updated the branch with master and replied to the comment. For this GA, au-syd is the only supported region, so DefaultServiceURL is ok.

padamstx · 2023-01-17T17:26:00Z

@adya1303 I just merged latest changes in main again. Is it time to merge the PR if the build is clean?

padamstx · 2023-01-18T21:25:19Z

We'll hold this PR out until @adya1303 gives the go-ahead, later this quarter.

Signed-off-by: ADYA NAND JHA <[email protected]>

padamstx · 2023-03-29T15:34:21Z

I did a re-review and the changes in the PR look good.
Before we merge this PR (IIRC the ETA is May/June when the service is GA), we'll need to make sure the PR is updated using the current "main" branch at the time, and we'll need screenshots showing clean results from running integration tests and examples. We can defer this until shortly before we plan to merge.

Signed-off-by: ADYA NAND JHA <[email protected]>

adya1303 · 2023-05-25T14:00:43Z

Tested with the latest code changes -
unit tests

~/Documents/GO/src/github.com/IBM/platform-services-go-sdk/metricsrouterv3 (add-mr-12132022) $ go test                       
Running Suite: MetricsRouterV3 Suite
====================================
Random Seed: 1685023090
Will run 83 of 83 specs

•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 83 of 83 Specs in 2.945 seconds
SUCCESS! -- 83 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok  	github.com/IBM/platform-services-go-sdk/metricsrouterv3	4.087s

integration tests

~/Documents/GO/src/github.com/IBM/platform-services-go-sdk/metricsrouterv3 (add-mr-12132022) $ go test -tags="integration" -v
=== RUN   TestMetricsRouterV3
Running Suite: MetricsRouterV3 Suite
====================================
Random Seed: 1685022846
Will run 123 of 123 specs
<some tests results output>
•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 123 of 123 Specs in 15.119 seconds
SUCCESS! -- 123 Passed | 0 Failed | 0 Pending | 0 Skipped

example tests

~/Documents/GO/src/github.com/IBM/platform-services-go-sdk/metricsrouterv3 (add-mr-12132022) $ go test -tags="examples" -v
=== RUN   TestMetricsRouterV3
Running Suite: MetricsRouterV3 Suite
====================================
Random Seed: 1685022970
Will run 97 of 97 specs

••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 97 of 97 Specs in 5.395 seconds
SUCCESS! -- 97 Passed | 0 Failed | 0 Pending | 0 Skipped

adya1303 · 2023-05-25T14:02:30Z

Hi, @padamstx, we are ready to merge the changes. Tested with the current code and have added the screenshots.
Could you merge the changes. Thanks

# [0.38.0](v0.37.4...v0.38.0) (2023-05-25) ### Features * **Metrics Router:** add new Metrics Router service to project ([#225](#225)) ([6eb402a](6eb402a))

ibm-devx-sdk · 2023-05-25T18:00:01Z

🎉 This PR is included in version 0.38.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

feat(Metrics Router): add metrics-router service to project

f77e823

Signed-off-by: ADYA NAND JHA <[email protected]>

adya1303 force-pushed the add-mr-12132022 branch from 9402cc6 to f77e823 Compare December 13, 2022 15:04

adya1303 marked this pull request as draft December 13, 2022 15:34

padamstx self-assigned this Dec 19, 2022

Merge branch 'main' into add-mr-12132022

a3baeed

adya1303 marked this pull request as ready for review January 3, 2023 03:56

padamstx approved these changes Jan 4, 2023

View reviewed changes

metricsrouterv3/metrics_router_v3.go Outdated Show resolved Hide resolved

Merge branch 'main' into add-mr-12132022

3a62370

Merge branch 'main' into add-mr-12132022

bd4c95d

padamstx and others added 4 commits March 15, 2023 13:21

Merge branch 'main' into add-mr-12132022

3b61b5f

Merge branch 'main' into add-mr-12132022

5674756

Added changes to work with latest API changes

430a535

Signed-off-by: ADYA NAND JHA <[email protected]>

Merge branch 'main' into add-mr-12132022

8f89712

padamstx and others added 3 commits April 5, 2023 15:19

Merge branch 'main' into add-mr-12132022

f9f38a6

Removed X-API-Maturity header from SDK

939fbf4

Signed-off-by: ADYA NAND JHA <[email protected]>

Merge branch 'main' into add-mr-12132022

5c2849c

padamstx changed the title ~~feat(Metrics Router): add metrics-router service to project~~ feat(Metrics Router): add new Metrics Router service to project May 25, 2023

padamstx merged commit 6eb402a into IBM:main May 25, 2023

ibm-devx-sdk pushed a commit that referenced this pull request May 25, 2023

chore(release): 0.38.0 release notes [skip ci]

02cba1d

# [0.38.0](v0.37.4...v0.38.0) (2023-05-25) ### Features * **Metrics Router:** add new Metrics Router service to project ([#225](#225)) ([6eb402a](6eb402a))

ibm-devx-sdk added the released label May 25, 2023

adya1303 deleted the add-mr-12132022 branch September 25, 2023 04:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Metrics Router): add new Metrics Router service to project #225

feat(Metrics Router): add new Metrics Router service to project #225

adya1303 commented Dec 13, 2022 •

edited

Loading

adya1303 commented Dec 14, 2022 •

edited

Loading

padamstx commented Dec 19, 2022

adya1303 commented Dec 21, 2022 •

edited

Loading

adya1303 commented Jan 3, 2023

padamstx left a comment

padamstx commented Jan 4, 2023

padamstx commented Jan 11, 2023

adya1303 commented Jan 17, 2023

padamstx commented Jan 17, 2023

padamstx commented Jan 18, 2023

padamstx commented Mar 29, 2023

adya1303 commented May 25, 2023

adya1303 commented May 25, 2023

ibm-devx-sdk commented May 25, 2023

feat(Metrics Router): add new Metrics Router service to project #225

feat(Metrics Router): add new Metrics Router service to project #225

Conversation

adya1303 commented Dec 13, 2022 • edited Loading

PR summary

PR Checklist

Does this PR introduce a breaking change?

Other information

adya1303 commented Dec 14, 2022 • edited Loading

padamstx commented Dec 19, 2022

adya1303 commented Dec 21, 2022 • edited Loading

adya1303 commented Jan 3, 2023

padamstx left a comment

Choose a reason for hiding this comment

padamstx commented Jan 4, 2023

padamstx commented Jan 11, 2023

adya1303 commented Jan 17, 2023

padamstx commented Jan 17, 2023

padamstx commented Jan 18, 2023

padamstx commented Mar 29, 2023

adya1303 commented May 25, 2023

adya1303 commented May 25, 2023

ibm-devx-sdk commented May 25, 2023

adya1303 commented Dec 13, 2022 •

edited

Loading

adya1303 commented Dec 14, 2022 •

edited

Loading

adya1303 commented Dec 21, 2022 •

edited

Loading