Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename Account_Summary billing_month property #222

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

Jdatechong
Copy link
Contributor

PR summary

Rename the billing_month property in the Account_Summary schema to month

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

The Account_Summary schema should now have the month property instead of the billing_month property.

Does this PR introduce a breaking change?

  • Yes
  • No

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need evidence that the integration tests and examples ran clean with your changes.

@Jdatechong
Copy link
Contributor Author

Ran 89 of 89 Specs in 15.552 seconds
SUCCESS! -- 89 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

^ result from running go test -tags=integration,examples

@padamstx padamstx merged commit 8d3a404 into IBM:main Dec 5, 2022
ibm-devx-sdk pushed a commit that referenced this pull request Dec 5, 2022
## [0.31.1](v0.31.0...v0.31.1) (2022-12-05)

### Bug Fixes

* **Usage Reports:** rename Account_Summary billing_month property ([#222](#222)) ([8d3a404](8d3a404))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.31.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

adya1303 pushed a commit that referenced this pull request Dec 6, 2022
adya1303 pushed a commit that referenced this pull request Dec 6, 2022
## [0.31.1](v0.31.0...v0.31.1) (2022-12-05)

### Bug Fixes

* **Usage Reports:** rename Account_Summary billing_month property ([#222](#222)) ([8d3a404](8d3a404))

Signed-off-by: ADYA NAND JHA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants