add list rule with service_group_id test #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
soohoowoohoo
suggested changes
Oct 12, 2022
| Expect(rule).ToNot(BeNil()) | ||
|
|
||
| //list rule with service_group_id | ||
| It(`ListRules(listRulesOptions *ListRulesOptions) with service_group_id (201)`, func() { |
There was a problem hiding this comment.
Listing rules should result in a 200
|
|
||
| Expect(err).To(Not(BeNil())) | ||
| Expect(response.StatusCode).To(Equal(201)) | ||
| Expect(ruleList).To(BeNil()) |
There was a problem hiding this comment.
I would expect the tests to assert that 1 rule was returned in the list and that it has the rule ID of the rule created above.
| ruleList, response, err := contextBasedRestrictionsService.ListRules(listRulesOptions) | ||
|
|
||
| Expect(err).To(Not(BeNil())) | ||
| Expect(response.StatusCode).To(Equal(201)) |
Signed-off-by: Cameron Davis <[email protected]>
Signed-off-by: Cameron Davis <[email protected]>
Signed-off-by: Cameron Davis <[email protected]>
cam-d12
force-pushed
the
cbr-service-group
branch
from
18d993f to
6ff9d10
Compare
Signed-off-by: Cameron Davis <[email protected]>
Signed-off-by: Cameron Davis <[email protected]>
Signed-off-by: Cameron Davis <[email protected]>
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Oct 14, 2022
## [0.28.6](v0.28.5...v0.28.6) (2022-10-14) ### Bug Fixes * **Context Based Restrictions:** add list rule with service_group_id test ([#208](#208)) ([e3b7581](e3b7581))
|
🎉 This PR is included in version 0.28.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This PR adds CBR support for the new service_group_id parameter in rules.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
No current behavior should be modified. Adds the further control to be able to apply rules to service groups
Does this PR introduce a breaking change?
Other information