-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Activity Tracker): Added support for event streams targets in Atracker v2 API #206
Conversation
57f619e
to
9dd0627
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a few changes needed in the integration tests to allow the tests to exercise all three target types independently.
Signed-off-by: Veena Rao <[email protected]>
Co-authored-by: Phil Adams <[email protected]> Signed-off-by: Veena Rao <[email protected]>
Co-authored-by: Phil Adams <[email protected]> Signed-off-by: Veena Rao <[email protected]>
Signed-off-by: Veena Rao <[email protected]>
5a3b11e
to
951c355
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could you please post a screenshot of a successful run of the atrackerv2 integration tests and examples for atrackerv2?
(e.g. cd atrackerv2
, go test -tags=integration,examples
)? Thanks!
Once we have those results, I'll go ahead and merge.
In the screen shot, it looks like you ran only unit and integration tests but not examples. You can use |
## [0.28.3](v0.28.2...v0.28.3) (2022-09-15) ### Bug Fixes * **Activity Tracker:** add support for event streams targets in Atracker v2 API ([#206](#206)) ([cc063b3](cc063b3))
🎉 This PR is included in version 0.28.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Signed-off-by: Veena Rao [email protected]
PR summary
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information