ResourceController service update #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: apoorva9s14 <[email protected]>
Signed-off-by: apoorva9s14 <[email protected]>
Signed-off-by: apoorva9s14 <[email protected]>
Signed-off-by: apoorva9s14 <[email protected]>
dpopp07
reviewed
Jul 26, 2022
| // string value identifies the level of access that's required to view the credential. For additional information, see | ||
| // [viewing a | ||
| // credential](https://cloud.ibm.com/docs/account?topic=account-service_credentials&interface=ui#viewing-credentials-ui). | ||
| Redacted *string `json:"REDACTED,omitempty"` |
There was a problem hiding this comment.
So where is this coming from? Was it added by hand? I don't see it in the API definition
There was a problem hiding this comment.
We have updated the api definition, the PR is merged in test, It is also merged in production - https://github.ibm.com/cloud-api-docs/resource-controller/pull/248
Signed-off-by: apoorva9s14 <[email protected]>
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Jul 27, 2022
# [0.27.0](v0.26.1...v0.27.0) (2022-07-27) ### Features * **Resource Controller:** regen to add new method ([#196](#196)) ([5272cdc](5272cdc))
|
🎉 This PR is included in version 0.27.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: apoorva9s14 [email protected]
PR summary
For the resource controller service update as per this PR - https://github.ibm.com/cloud-api-docs/resource-controller/pull/244, resource-controller-v2.yaml is the updated yaml, I have regenerated the SDK files with openapi-sdkgen.
We are looking to address:
Looping - https://github.ibm.com/cloud-api-docs/resource-controller/issues/226
Credentials redaction
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
The examples and the SDK code snippet in the apidocs would be updated for credentials redaction
Does this PR introduce a breaking change?
Other information