fix: bump deps, fix lint errors #190
Conversation
This commit includes the following changes: 1. Some dependencies were bumped to newer versions 2. The build will now lint-check integration tests and examples 3. Changes to allow the int tests and examples to lint-check cleanly
| @@ -47,24 +48,25 @@ import ( | |||
| // in a configuration file and then: | |||
| // export IBM_CREDENTIALS_FILE=<name of configuration file> | |||
| // | |||
| const externalConfigFile = "../case_management.env" | |||
There was a problem hiding this comment.
To satisfy the linter, I moved all these "global definitions" within examples and int tests into the outer-most Describe() block. That way there are not conflicts between the examples and int tests for a given service. These problems only started showing up after I changed the Makefile's "lint" target to include the build tags so that all source files (not just the service and unit tests) are now being lint-checked.
There was a problem hiding this comment.
Sounds good! Are these changes that will need to be propagated to the generator?
There was a problem hiding this comment.
Sounds good! Are these changes that will need to be propagated to the generator?
I opened this issue to make sure the Go generator is updated as needed.
| @@ -47,24 +48,25 @@ import ( | |||
| // in a configuration file and then: | |||
| // export IBM_CREDENTIALS_FILE=<name of configuration file> | |||
| // | |||
| const externalConfigFile = "../case_management.env" | |||
There was a problem hiding this comment.
Sounds good! Are these changes that will need to be propagated to the generator?
## [0.25.2](v0.25.1...v0.25.2) (2022-05-31) ### Bug Fixes * bump deps, fix lint errors ([#190](#190)) ([073cdb2](073cdb2))
|
🎉 This PR is included in version 0.25.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR summary
This commit includes the following changes:
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information