Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Activity Tracker): add new atracker v2 service to project #175

Merged
merged 7 commits into from
May 4, 2022
Merged

feat(Activity Tracker): add new atracker v2 service to project #175

merged 7 commits into from
May 4, 2022

Conversation

johnymathew
Copy link
Contributor

PR summary

SDK for Atracker services v2 API pushing into atrackerv2 folder. There is a v1 version available in atrackerv1 folder

PR Checklist

Please make sure that your PR fulfills the following requirements:

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@padamstx padamstx changed the title New SDK version: atracker v2 api sdk changes feat(Activity Tracker): add new atracker v2 service to project Mar 11, 2022
@johnymathew
Copy link
Contributor Author

Screen Shot 2022-03-16 at 6 36 01 PM

@padamstx padamstx self-assigned this Mar 17, 2022
@padamstx padamstx self-requested a review March 17, 2022 15:23
padamstx
padamstx approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

padamstx
padamstx requested changes Mar 17, 2022
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I approved, but then realized we need to update the README.md file as well.

padamstx
padamstx requested changes Apr 15, 2022
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but we still need to update the README.md file to include the new service :)

padamstx
padamstx approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 5caec67 into main May 4, 2022
@padamstx padamstx deleted the v2changes branch May 4, 2022 15:41
ibm-devx-sdk pushed a commit that referenced this pull request May 4, 2022
@semantic-release-bot
chore(release): 0.25.0 release notes [skip ci]
11ceaec 
# [0.25.0](v0.24.1...v0.25.0) (2022-05-04)

### Features

* **Activity Tracker:** add new atracker v2 service to project ([#175](#175)) ([5caec67](5caec67))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnymathew @CLAassistant @ibm-devx-sdk @padamstx