-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iam-identity): adding trusted profiles #149
feat(iam-identity): adding trusted profiles #149
Conversation
FYI... when this PR is merged into main, we'll need to modify the commit message because it doesn't conform to the Angular style required by semantic-release :) |
I found an inconsistency between the java and go examples. Can I ask you to make a small modification there too? It(`GetAPIKey request example`, func() {
fmt.Println("\nGetAPIKey() result:")
// begin-get_api_key
getAPIKeyOptions := iamIdentityService.NewGetAPIKeyOptions(apikeyID)
apiKey, response, err := iamIdentityService.GetAPIKey(getAPIKeyOptions)
if err != nil {
panic(err)
}
apikeyEtag = response.GetHeaders().Get("Etag")
b, _ := json.MarshalIndent(apiKey, "", " ")
fmt.Println(string(b))
// end-get_api_key
Expect(err).To(BeNil())
Expect(response.StatusCode).To(Equal(200))
Expect(apiKey).ToNot(BeNil())
Expect(apikeyEtag).ToNot(BeEmpty())
}) |
8b52476
to
7c77b39
Compare
6ffc8ae
to
6dd1cf6
Compare
5d5b9e0
to
21d343c
Compare
this PR is now updated, all the requested changes are made :) |
21d343c
to
94b39d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small fixes needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the PR build finishes and it is green I'll merge it.
# [0.20.0](v0.19.4...v0.20.0) (2021-09-02) ### Features * **iam-identity:** adding trusted profiles ([#149](#149)) ([e67f872](e67f872))
🎉 This PR is included in version 0.20.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR summary
This pr contains all the supported endpoints of Iam-Identity's trusted profiles.
we recently went public and here is the documentation: https://test.cloud.ibm.com/apidocs/iam-identity-token-api
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information