Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iam-identity): adding trusted profiles #149

Merged
merged 5 commits into from
Sep 2, 2021

Conversation

pooraniss-ibm
Copy link
Member

@pooraniss-ibm pooraniss-ibm commented Aug 24, 2021

PR summary

This pr contains all the supported endpoints of Iam-Identity's trusted profiles.
we recently went public and here is the documentation: https://test.cloud.ibm.com/apidocs/iam-identity-token-api

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Screenshot 2021-08-25 at 01 02 09

@CLAassistant
Copy link

CLAassistant commented Aug 24, 2021

CLA assistant check
All committers have signed the CLA.

@padamstx
Copy link
Member

FYI... when this PR is merged into main, we'll need to modify the commit message because it doesn't conform to the Angular style required by semantic-release :)

@Andras-Csanyi
Copy link
Contributor

I found an inconsistency between the java and go examples. Can I ask you to make a small modification there too?
The include history false is missing from the following code snippet, however we have it in the java examples. It is important from that point of view we want to display the same code snippets in all the languages in the reference. It elevates user experience and makes easier to use the SDKs.
Thank you very much for your help in this case!

It(`GetAPIKey request example`, func() {
			fmt.Println("\nGetAPIKey() result:")
			// begin-get_api_key
			getAPIKeyOptions := iamIdentityService.NewGetAPIKeyOptions(apikeyID)
			apiKey, response, err := iamIdentityService.GetAPIKey(getAPIKeyOptions)
			if err != nil {
				panic(err)
			}
			apikeyEtag = response.GetHeaders().Get("Etag")
			b, _ := json.MarshalIndent(apiKey, "", "  ")
			fmt.Println(string(b))
			// end-get_api_key
			Expect(err).To(BeNil())
			Expect(response.StatusCode).To(Equal(200))
			Expect(apiKey).ToNot(BeNil())
			Expect(apikeyEtag).ToNot(BeEmpty())
		})

@pooraniss-ibm pooraniss-ibm force-pushed the iam-identity-trustedprofiles branch from 8b52476 to 7c77b39 Compare August 30, 2021 09:06
@pooraniss-ibm pooraniss-ibm force-pushed the iam-identity-trustedprofiles branch from 6ffc8ae to 6dd1cf6 Compare August 30, 2021 12:57
@pooraniss-ibm pooraniss-ibm force-pushed the iam-identity-trustedprofiles branch from 5d5b9e0 to 21d343c Compare September 2, 2021 09:51
@pooraniss-ibm
Copy link
Member Author

this PR is now updated, all the requested changes are made :)

@pooraniss-ibm pooraniss-ibm force-pushed the iam-identity-trustedprofiles branch from 21d343c to 94b39d1 Compare September 2, 2021 13:19
Copy link
Contributor

@Andras-Csanyi Andras-Csanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small fixes needed.

@Andras-Csanyi Andras-Csanyi self-requested a review September 2, 2021 14:00
Copy link
Contributor

@Andras-Csanyi Andras-Csanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the PR build finishes and it is green I'll merge it.

@Andras-Csanyi Andras-Csanyi changed the title iam-identity: adding trusted profiles feat(iam-identity): adding trusted profiles Sep 2, 2021
@Andras-Csanyi Andras-Csanyi merged commit e67f872 into IBM:main Sep 2, 2021
ibm-devx-sdk pushed a commit that referenced this pull request Sep 2, 2021
# [0.20.0](v0.19.4...v0.20.0) (2021-09-02)

### Features

* **iam-identity:** adding trusted profiles ([#149](#149)) ([e67f872](e67f872))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants