Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Activity Tracker): re-gen service after recent service name change #142

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

yingwang-us
Copy link
Member

@yingwang-us yingwang-us commented Aug 2, 2021

PR summary

  • service name is changed from activity tracking to activity tracker, therefore update apidoc as well as sdk
  • update atracker GA api endpoints, for GA we only support us-east / us-south public and private endpoints

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@yingwang-us yingwang-us requested a review from padamstx August 2, 2021 21:43
@yingwang-us
Copy link
Member Author

yings-mbp:atrackerv1 [email protected]$ go test
Running Suite: AtrackerV1 Suite
===============================
Random Seed: 1627940380
Will run 91 of 91 specs

•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 91 of 91 Specs in 3.474 seconds
SUCCESS! -- 91 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok  	github.com/IBM/platform-services-go-sdk/atrackerv1	4.981s

@yingwang-us
Copy link
Member Author

yings-mbp:platform-services-go-sdk [email protected]$ go test github.com/IBM/platform-services-go-sdk/atrackerv1 -tags="integration" -v
=== RUN   TestAtrackerV1
Running Suite: AtrackerV1 Suite
===============================
Random Seed: 1627939164
Will run 129 of 129 specs

Service URL: http://localhost:6969
•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 129 of 129 Specs in 11.779 seconds
SUCCESS! -- 129 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestAtrackerV1 (11.80s)
PASS
ok  	github.com/IBM/platform-services-go-sdk/atrackerv1	(cached)

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Andras-Csanyi Andras-Csanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Andras-Csanyi Andras-Csanyi merged commit 972853e into main Aug 3, 2021
ibm-devx-sdk pushed a commit that referenced this pull request Aug 3, 2021
## [0.19.3](v0.19.2...v0.19.3) (2021-08-03)

### Bug Fixes

* **Activity Tracker:** re-gen service after recent service name change ([#142](#142)) ([972853e](972853e))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.19.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Andras-Csanyi Andras-Csanyi deleted the regen-atracker-0802 branch August 3, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants