Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add integration tests for resource manager service #14

Merged
merged 1 commit into from
May 12, 2020
Merged

test: add integration tests for resource manager service #14

merged 1 commit into from
May 12, 2020

Conversation

inamdarapurva
Copy link
Contributor

PR summary

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@inamdarapurva inamdarapurva requested review from padamstx and mahakAg May 11, 2020 23:00
@inamdarapurva inamdarapurva self-assigned this May 11, 2020
padamstx
padamstx approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit e803dbd into add-rm May 12, 2020
@padamstx padamstx deleted the add-rm-integration branch May 12, 2020 12:27
padamstx added a commit that referenced this pull request May 12, 2020
@padamstx
feat(Resource Manager): add service to project (#9)
6aa9cc1 
* feat(Resource Manager): add service to project
* chore: re-gen service with latest API definition
* test: add integration tests for resource manager service (#14)
Co-authored-by: inamdarapurva <[email protected]>
ibm-devx-automation pushed a commit that referenced this pull request May 12, 2020
@semantic-release-bot
chore(release): 0.3.0 release notes [skip ci]
e3c6031 
# [0.3.0](v0.2.0...v0.3.0) (2020-05-12)

### Features

* **Resource Manager:** add service to project ([#9](#9)) ([6aa9cc1](6aa9cc1)), closes [#14](#14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

@mahakAg mahakAg Awaiting requested review from mahakAg

Assignees

@inamdarapurva inamdarapurva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inamdarapurva @padamstx