Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Usage Reports): add optional name parameters to struct #139

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

KRuelY
Copy link
Member

@KRuelY KRuelY commented Jul 22, 2021

PR summary

add optional name parameters to data type

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Names will now show up when the optional parameter _names is passed

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

•••••••••••••••••••••••••••••••••••••••••••
Ran 65 of 65 Specs in 12.685 seconds
SUCCESS! -- 65 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok  	github.com/IBM/platform-services-go-sdk/usagereportsv4	12.953s

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Kevin Yudhiswara seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@Andras-Csanyi Andras-Csanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Let's wait until the PRs in the other SDKs are reviewed/approved before merging this one in.

@Andras-Csanyi Andras-Csanyi merged commit 64af32f into IBM:main Jul 29, 2021
ibm-devx-sdk pushed a commit that referenced this pull request Jul 29, 2021
## [0.19.2](v0.19.1...v0.19.2) (2021-07-29)

### Bug Fixes

* **usage reports:** add optional name parameters to struct ([#139](#139)) ([64af32f](64af32f))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.19.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants