fix(Activity Tracker): re-gen service after recent API changes

[yingwang-us]

PR summary

add endpoint sdk functions based on 2 new endpoints api for atracker service

PR Checklist

Please make sure that your PR fulfills the following requirements:

• The commit message follows the Angular Commit Message Guidelines.
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

• Yes
• No

Other information

unit test results:

yings-mbp:atrackerv1 [email protected]$ go test
Running Suite: AtrackerV1 Suite
===============================
Random Seed: 1625603641
Will run 91 of 91 specs

•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 91 of 91 Specs in 3.505 seconds
SUCCESS! -- 91 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok  	github.com/IBM/platform-services-go-sdk/atrackerv1	3.986s

integration test results:

yings-mbp:platform-services-go-sdk [email protected]$ go test github.com/IBM/platform-services-go-sdk/atrackerv1 -tags="integration" -v
=== RUN   TestAtrackerV1
Running Suite: AtrackerV1 Suite
===============================
Random Seed: 1625603255
Will run 106 of 106 specs

Service URL: http://localhost:6969
••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 106 of 106 Specs in 9.148 seconds
SUCCESS! -- 106 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestAtrackerV1 (9.45s)
PASS
ok  	github.com/IBM/platform-services-go-sdk/atrackerv1	(cached)

[Andras-Csanyi]

I reached out to Ying via Slack and asked for the api def file was used to re-gen the sdk. The activity repo has an, seemingly, outdated one.

[Andras-Csanyi]

Looks good!

I'd like to ask you to add further test cases to the integration suite covering 400, 403 and 404 status codes for both new operation. If you can test easily and programmatically 429 then please add that too.

We'd like to achieve that all the status codes mentioned in the api definition file are exercised by integration tests. There are exceptions like 401, but we can live with that.

You can find examples (link below), especially how to create a new client not having enough rights to do things so the server returns 403.
https://github.com/IBM/platform-services-go-sdk/blob/main/catalogmanagementv1/catalog_management_v1_integration_new_test.go

Feel free to ping me if you need any help.

[padamstx]

LGTM
I agree with @Andras-Csanyi that it would be good to augment the integration tests to include negative tests that exercise each of the error status codes that are explicitly defined in the API definition. We haven't always done this in the SDK int tests, but it's a good practice to follow going forward. I'll approve now to avoid a re-review assuming these negative tests are added.

[yingwang-us]

@Andras-Csanyi @padamstx thanks for reviewing, I have add some 20+ negative test cases (400, 404, 403) for integration tests. For the 2 new Endpoints APIs, it seems hard to simulate 400 error and 404 error is removed from apidoc, so I just include 403 negative tests for them. Please help review, thanks.

here are new integration test results:

Yings-MacBook-Pro:platform-services-go-sdk [email protected]$ go test github.com/IBM/platform-services-go-sdk/atrackerv1 -tags="integration" -v
=== RUN   TestAtrackerV1
Running Suite: AtrackerV1 Suite
===============================
Random Seed: 1625783375
Will run 129 of 129 specs

Service URL: http://localhost:6969
•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 129 of 129 Specs in 9.984 seconds
SUCCESS! -- 129 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestAtrackerV1 (10.13s)
PASS
ok  	github.com/IBM/platform-services-go-sdk/atrackerv1	(cached)

[Andras-Csanyi]

Looks really good!
Thank you for adding the negative tests!

[ibm-devx-sdk]

🎉 This PR is included in version 0.19.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀