Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add channel and install plan to cat-mgmt offering instance #125

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

JonWoodlief
Copy link
Member

PR summary

Add capability to provide a channel and install plan to offering instances

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Adding new options (optional)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. When merging, let's use a "fix" type commit so that we increment the patch level instead of the minor version.

@padamstx padamstx merged commit 9f5a90c into IBM:main Jun 7, 2021
ibm-devx-sdk pushed a commit that referenced this pull request Jun 7, 2021
## [0.18.15](v0.18.14...v0.18.15) (2021-06-07)

### Bug Fixes

* **Catalog Management:** add channel and install plan to catalog management offering instance ([#125](#125)) ([9f5a90c](9f5a90c))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.18.15 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants