fix(IAM Identity): update service after recent API changes #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrooka
commented
Apr 22, 2021
pyrooka
commented
Apr 22, 2021
| @@ -604,6 +604,7 @@ var _ = Describe(`IamIdentityV1 Integration Tests`, func() { | |||
| Mfa: core.StringPtr("NONE"), | |||
| SessionExpirationInSeconds: core.StringPtr("86400"), | |||
| SessionInvalidationInSeconds: core.StringPtr("7200"), | |||
| MaxSessionsPerIdentity: core.StringPtr("10"), | |||
There was a problem hiding this comment.
@padamstx Can we skip adding this parameter to the examples or we should do it?
padamstx
approved these changes
Apr 26, 2021
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Apr 26, 2021
## [0.18.10](v0.18.9...v0.18.10) (2021-04-26) ### Bug Fixes * **IAM Identity:** update service after recent API changes ([#116](#116)) ([cb50bf3](cb50bf3))
|
🎉 This PR is included in version 0.18.10 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This PR contains the re-generated IAM Identity service and the updated integration tests.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information