fix(enterprise manager): update enterprise management after recent api changes #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: András Csányi <[email protected]>
padamstx
approved these changes
Apr 7, 2021
| BeforeEach(func() { | ||
| shouldSkipTest() | ||
| }) | ||
| It(`CreateAccountGroup(createAccountGroupOptions *CreateAccountGroupOptions)`, func() { |
There was a problem hiding this comment.
I think a cleaner way to create 2 account groups would be to have two separate It() blocks, with each one creating a single account group.
| BeforeEach(func() { | ||
| shouldSkipTest() | ||
| }) | ||
| It(`ListAccountGroups(listAccountGroupsOptions *ListAccountGroupsOptions)`, func() { |
There was a problem hiding this comment.
Let's re-code this test so that it uses a loop to retrieve a page at a time (perhaps use limit=1?) and accumulate the results in a slice, similar to how the user-management int tests exercise the list-type operations.
|
|
||
| It("Successfully Create Account", func() { | ||
| shouldSkipTest() | ||
| listEnterprisesOptions := &enterprisemanagementv1.ListEnterprisesOptions{ |
There was a problem hiding this comment.
Need to exercise pagination for this operation as well.
ibm-devx-automation
pushed a commit
that referenced
this pull request
Apr 7, 2021
## [0.18.6](v0.18.5...v0.18.6) (2021-04-07) ### Bug Fixes * **enterprise manager:** update enterprise management after recent api changes ([#107](#107)) ([3a11a67](3a11a67))
|
🎉 This PR is included in version 0.18.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This PR updates Enterprise Manager Service SDK.
Old integration tests using Account Manager private api endpoints has been removed. There are SDK methods still untested due to that they require account creation programatically, and unfortunateley we don't have that yet.
These methods:
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information