Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate tasks in check.yml #305

Open
acch opened this issue Nov 25, 2020 · 1 comment
Open

Duplicate tasks in check.yml #305

acch opened this issue Nov 25, 2020 · 1 comment
Assignees
Labels
Component: Core Type: Enhancement Type: Enhancement Indicates a request for feature to be improved.

Comments

@acch
Copy link
Contributor

acch commented Nov 25, 2020

The files core/common/tasks/check.yml and core/cluster/tasks/check.yml contain the same tasks. As all roles depend on core/common these tasks are redundant, and can be merged into a single file. Running these tasks twice simply increases runtime, and multiple definitions of the same variable are error-prone.

Duplicate tasks:

  • "check | Count daemon processes"
  • "check | Check if daemon is running"
  • "check | Set default daemon nodename"
@acch acch added Type: Enhancement Type: Enhancement Indicates a request for feature to be improved. Component: Core labels Nov 25, 2020
@acch acch self-assigned this Nov 25, 2020
@rajan-mis
Copy link
Member

@acch Thanks. I was also thinking this but here we will have one issue and that we need to fix. if we are going to merge core/cluster/tasks/check.yml in the core/common/tasks/check.yml then core/cluster can not be used without core/common role but then this dependency always required SE package and scale_version variable but currently this independent role is getting consumed by ESS deployment and was also getting used by CNSS team independently without passing SE package or scale version because scale_version variable is not getting used in the core/cluster role. so we will have ton fix this before merging this into single. I also agree to remove this duplicate tasks. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Type: Enhancement Type: Enhancement Indicates a request for feature to be improved.
Projects
None yet
Development

No branches or pull requests

2 participants