Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missing inputs inputs to tiles #228

Merged
merged 9 commits into from
Mar 31, 2023
Merged

Conversation

MoizMasud
Copy link
Contributor

@MoizMasud MoizMasud commented Feb 11, 2023

Signed-off-by: Moiz Masud [email protected]
closes #58

Signed-off-by: Moiz Masud <[email protected]>
@MoizMasud MoizMasud added the enhancement New feature or request label Feb 11, 2023
@MoizMasud MoizMasud self-assigned this Feb 11, 2023
@netlify
Copy link

netlify bot commented Feb 11, 2023

Deploy Preview for carbon-components-builder ready!

Name Link
🔨 Latest commit 116bc61
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-builder/deploys/64271bb2ee723a00086d22dd
😎 Deploy Preview https://deploy-preview-228--carbon-components-builder.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MoizMasud MoizMasud marked this pull request as draft February 11, 2023 19:21
@MoizMasud MoizMasud marked this pull request as ready for review February 23, 2023 18:32
Copy link
Member

@zvonimirfras zvonimirfras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a semicolon is missing in a few places in export, double-check locally (adding it shouldn't break anything).

src/fragment-components/tiles/a-clickable-tile.tsx Outdated Show resolved Hide resolved
src/fragment-components/tiles/a-radio-tile.tsx Outdated Show resolved Hide resolved
src/fragment-components/tiles/a-selectable-tile.tsx Outdated Show resolved Hide resolved
@MoizMasud MoizMasud requested a review from zvonimirfras March 3, 2023 16:16
@zvonimirfras zvonimirfras merged commit 6783ca5 into IBM:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing tile inputs to angular code exports
2 participants