feat: Add missing features to Search component #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moiz Masud <[email protected]>
Signed-off-by: Moiz Masud <[email protected]>
✅ Deploy Preview for carbon-components-builder ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
MoizMasud
requested review from
Akshat55 and
zvonimirfras
and removed request for
Akshat55
Signed-off-by: Moiz Masud <[email protected]>
Signed-off-by: Moiz Masud <[email protected]>
Akshat55
approved these changes
Nov 28, 2022
Akshat55
requested changes
Nov 30, 2022
Co-authored-by: Akshat Patel <[email protected]>
Co-authored-by: Akshat Patel <[email protected]>
Co-authored-by: Akshat Patel <[email protected]>
Co-authored-by: Akshat Patel <[email protected]>
Co-authored-by: Akshat Patel <[email protected]>
Co-authored-by: Akshat Patel <[email protected]>
Co-authored-by: Akshat Patel <[email protected]>
Co-authored-by: Akshat Patel <[email protected]>
Co-authored-by: Akshat Patel <[email protected]>
Signed-off-by: Moiz Masud <[email protected]>
Akshat55
approved these changes
Nov 30, 2022
Akshat55
requested changes
Nov 30, 2022
Akshat55
approved these changes
Nov 30, 2022
zvonimirfras
approved these changes
Nov 30, 2022
| light: checked | ||
| })} /> | ||
| <Checkbox | ||
| labelText='AutoComplete' |
There was a problem hiding this comment.
Suggested change
| labelText='AutoComplete' | |
| labelText='Autocomplete' |
| <Checkbox | ||
| labelText='AutoComplete' | ||
| id='autoComplete' | ||
| checked={selectedComponent.autoComplete === 'on'} |
There was a problem hiding this comment.
Suggested change
| checked={selectedComponent.autoComplete === 'on'} | |
| checked={selectedComponent.autocomplete === 'on'} |
| checked={selectedComponent.autoComplete === 'on'} | ||
| onChange={(checked: any) => setComponent({ | ||
| ...selectedComponent, | ||
| autoComplete: checked ? 'on' : 'off' |
There was a problem hiding this comment.
Suggested change
| autoComplete: checked ? 'on' : 'off' | |
| autocomplete: checked ? 'on' : 'off' |
| })} /> | ||
| <Checkbox | ||
| labelText='Auto complete' | ||
| id='autoComplete' |
There was a problem hiding this comment.
Suggested change
| id='autoComplete' | |
| id='autocomplete' |
MoizMasud
added a commit
to MoizMasud/carbon-components-builder
that referenced
this pull request
Dec 7, 2022
* Add missing properties to search component Signed-off-by: Moiz Masud <[email protected]> * Add props to ui-search preview file Signed-off-by: Moiz Masud <[email protected]> * Lint fix Signed-off-by: Moiz Masud <[email protected]> * Lint fix Signed-off-by: Moiz Masud <[email protected]> * Update src/ui-fragment/src/components/ui-serach-input.tsx Co-authored-by: Akshat Patel <[email protected]> * Update src/fragment-components/a-searchinput.tsx Co-authored-by: Akshat Patel <[email protected]> * Update src/fragment-components/a-searchinput.tsx Co-authored-by: Akshat Patel <[email protected]> * Update src/fragment-components/a-searchinput.tsx Co-authored-by: Akshat Patel <[email protected]> * Update src/fragment-components/a-searchinput.tsx Co-authored-by: Akshat Patel <[email protected]> * Update src/fragment-components/a-searchinput.tsx Co-authored-by: Akshat Patel <[email protected]> * Update src/fragment-components/a-searchinput.tsx Co-authored-by: Akshat Patel <[email protected]> * Update src/fragment-components/a-searchinput.tsx Co-authored-by: Akshat Patel <[email protected]> * Update src/ui-fragment/src/components/ui-serach-input.tsx Co-authored-by: Akshat Patel <[email protected]> * Change auto complete naming convention Signed-off-by: Moiz Masud <[email protected]> * Update src/fragment-components/a-searchinput.tsx Signed-off-by: Moiz Masud <[email protected]> Co-authored-by: Akshat Patel <[email protected]> Signed-off-by: Moiz Masud <[email protected]>
connorAhearn
pushed a commit
to connorAhearn/carbon-ui-builder-actions-ui
that referenced
this pull request
Jun 29, 2023
* Add missing properties to search component Signed-off-by: Moiz Masud <[email protected]> * Add props to ui-search preview file Signed-off-by: Moiz Masud <[email protected]> * Lint fix Signed-off-by: Moiz Masud <[email protected]> * Lint fix Signed-off-by: Moiz Masud <[email protected]> * Update src/ui-fragment/src/components/ui-serach-input.tsx Co-authored-by: Akshat Patel <[email protected]> * Update src/fragment-components/a-searchinput.tsx Co-authored-by: Akshat Patel <[email protected]> * Update src/fragment-components/a-searchinput.tsx Co-authored-by: Akshat Patel <[email protected]> * Update src/fragment-components/a-searchinput.tsx Co-authored-by: Akshat Patel <[email protected]> * Update src/fragment-components/a-searchinput.tsx Co-authored-by: Akshat Patel <[email protected]> * Update src/fragment-components/a-searchinput.tsx Co-authored-by: Akshat Patel <[email protected]> * Update src/fragment-components/a-searchinput.tsx Co-authored-by: Akshat Patel <[email protected]> * Update src/fragment-components/a-searchinput.tsx Co-authored-by: Akshat Patel <[email protected]> * Update src/ui-fragment/src/components/ui-serach-input.tsx Co-authored-by: Akshat Patel <[email protected]> * Change auto complete naming convention Signed-off-by: Moiz Masud <[email protected]> * Update src/fragment-components/a-searchinput.tsx Signed-off-by: Moiz Masud <[email protected]> Co-authored-by: Akshat Patel <[email protected]> Signed-off-by: Connor-Ahearn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Moiz Masud [email protected]
closes #19
check off Search here: #134