Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missing functionality to code-snippet #126

Merged
merged 15 commits into from
Dec 8, 2022

Conversation

MoizMasud
Copy link
Contributor

@MoizMasud MoizMasud commented Jul 19, 2022

No description provided.

@MoizMasud MoizMasud requested a review from zvonimirfras July 19, 2022 22:27
@netlify
Copy link

netlify bot commented Jul 19, 2022

Deploy Preview for carbon-components-builder ready!

Name Link
🔨 Latest commit 9d5496f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-builder/deploys/639130c16103530009e27258
😎 Deploy Preview https://deploy-preview-126--carbon-components-builder.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@zvonimirfras zvonimirfras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing updates in UICodeSnippet?

src/fragment-components/a-code-snippet.tsx Outdated Show resolved Hide resolved
@MoizMasud MoizMasud closed this Jul 21, 2022
@MoizMasud MoizMasud reopened this Jul 21, 2022
@MoizMasud MoizMasud marked this pull request as draft July 21, 2022 18:29
@MoizMasud MoizMasud marked this pull request as ready for review August 9, 2022 01:44
Signed-off-by: Moiz Masud <[email protected]>
@MoizMasud MoizMasud requested a review from Akshat55 November 21, 2022 19:45
Signed-off-by: Moiz Masud <[email protected]>
Signed-off-by: Moiz Masud <[email protected]>
@MoizMasud MoizMasud requested a review from Akshat55 November 22, 2022 05:20
@MoizMasud MoizMasud changed the title Add missing functionality to code-snippet feat: Add missing functionality to code-snippet Nov 29, 2022
Signed-off-by: Moiz Masud <[email protected]>
@zvonimirfras zvonimirfras merged commit bed839f into IBM:main Dec 8, 2022
connorAhearn pushed a commit to connorAhearn/carbon-ui-builder-actions-ui that referenced this pull request Jun 29, 2023
* Add missing functionality to code-snippet

* Fix light export

* Update src/fragment-components/a-code-snippet.tsx

Co-authored-by: Zvonimir Fras <[email protected]>

* Fix indentation

Signed-off-by: Moiz Masud <[email protected]>

* Update angular export package version

Signed-off-by: Moiz Masud <[email protected]>

* Update src/routes/edit/share-options/exports/frameworks/angular-fragment.ts

Co-authored-by: Akshat Patel <[email protected]>

* -s

* Updated carbon react export package version

* Update src/fragment-components/a-code-snippet.tsx

Co-authored-by: Zvonimir Fras <[email protected]>

* Add light to code export

Signed-off-by: Moiz Masud <[email protected]>

Signed-off-by: Moiz Masud <[email protected]>
Co-authored-by: Moiz Masud <[email protected]>
Co-authored-by: Zvonimir Fras <[email protected]>
Co-authored-by: Akshat Patel <[email protected]>
Signed-off-by: Connor-Ahearn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants