fix: move the current selector to fix scoping issues #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit 2294c23 https://deploy-preview-1728--the-carbon-components.netlify.com |
asudoh
approved these changes
Feb 5, 2019
lovemecomputer
approved these changes
Feb 6, 2019
|
🎉 This PR is included in version 9.70.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1711 for all instances that I'm presently aware of
TL;DR from the issue:
If
&is used as a second level selector, it inherits the entire first level selector. So.#{$prefix}--structured-list-rowbecomes.carbon .bx--structured-list-rowand.#{$prefix}--structured-list--selection &:hover:not(.#{$prefix}--structured-list-row--header-row)becomes
instead of
This PR moves a few of the selectors around. This does result in a few styles moving away from their direct container, but it does express the intent of the selectors better.
As far as I can tell none of the X styles are affected by this.