fix(Pagination): pageInputDisabled won't disable buttons (#2264) (#2278)

carbon-design-system · Apr 30, 2019 · b910758 · b910758
1 parent 3e9862c
commit b910758
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 4 deletions.
diff --git a/src/components/Pagination/Pagination-test.js b/src/components/Pagination/Pagination-test.js
@@ -353,6 +353,29 @@ describe('Pagination', () => {
           );
           expect(right.length).toEqual(0);
         });
+
+        it('should not append `pagination__button--no-index` class if input is disabled', () => {
+          const pagination = shallow(
+            <Pagination
+              page={2}
+              pageSizes={[100]}
+              pagesUnknown={true}
+              pageInputDisabled={true}
+            />
+          );
+          const forwardButton = pagination.find(
+            '.bx--pagination__button--forward'
+          );
+          const backwardButton = pagination.find(
+            '.bx--pagination__button--backward'
+          );
+          expect(
+            backwardButton.hasClass('bx--pagination__button--no-index')
+          ).toEqual(false);
+          expect(
+            forwardButton.hasClass('bx--pagination__button--no-index')
+          ).toEqual(false);
+        });
       });
 
       describe('pagination navigation', () => {

diff --git a/src/components/Pagination/Pagination.js b/src/components/Pagination/Pagination.js
@@ -260,8 +260,7 @@ export default class Pagination extends Component {
       `${prefix}--pagination__button`,
       `${prefix}--pagination__button--backward`,
       {
-        [`${prefix}--pagination__button--no-index`]:
-          pageInputDisabled || backButtonDisabled,
+        [`${prefix}--pagination__button--no-index`]: backButtonDisabled,
       }
     );
     const forwardButtonDisabled =
@@ -270,8 +269,7 @@ export default class Pagination extends Component {
       `${prefix}--pagination__button`,
       `${prefix}--pagination__button--forward`,
       {
-        [`${prefix}--pagination__button--no-index`]:
-          pageInputDisabled || forwardButtonDisabled,
+        [`${prefix}--pagination__button--no-index`]: forwardButtonDisabled,
       }
     );
     const selectItems = this.renderSelectItems(totalPages);