Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advertise system and type-level history in CapabilityStatement #3184

Closed
lmsurpre opened this issue Jan 12, 2022 · 1 comment
Closed

Advertise system and type-level history in CapabilityStatement #3184

lmsurpre opened this issue Jan 12, 2022 · 1 comment
Assignees
@lmsurpre
Labels
enhancement New feature or request

Comments

@lmsurpre
Copy link
Member

lmsurpre commented Jan 12, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
In #2972 we added support for type-level history.
However, we forgot to advertise this new capability in our CapabilityStatement

Describe the solution you'd like
Add history-type to the list of supported interactions for each resource type on the server: https://www.hl7.org/fhir/capabilitystatement-definitions.html#CapabilityStatement.rest.resource.interaction.code

Describe alternatives you've considered

Acceptance Criteria

  1. GIVEN fhirServer/resources/Resource/interactions is present and doesn't list 'seach' or 'history' (i.e. whole-system search and history are disabled)
    WHEN /metadata is invoked
    THEN the response does not list search-system and history-system as supported interactions

  2. GIVEN whole-system search and history are enabled
    WHEN /metadata is invoked
    THEN the response does list search-system and history-system as supported interactions

  3. GIVEN search and history are disabled for the Patient resource
    WHEN /metadata is invoked
    THEN the response does not list search-type, history-type, and history-instance as supported interactions for this resource type

  4. GIVEN search and history are enabled for the Patient resource
    WHEN /metadata is invoked
    THEN the response does list search-type, history-type, and history-instance as supported interactions for this resource type

I didn’t list every possible thing, but hopefully the intent is clear. It should be for all resource types, not just Patient.
And you can configure search and history independently

Additional context
While at it, we should also start setting https://www.hl7.org/fhir/capabilitystatement-definitions.html#CapabilityStatement.rest.resource.readHistory to true to indicate that we can "return past versions as part of the vRead operation". I thought was kind of a given with vread, but apparently not.
@lmsurpre lmsurpre added the enhancement New feature or request label Jan 12, 2022
@lmsurpre lmsurpre self-assigned this Jan 12, 2022
lmsurpre added a commit that referenced this issue Jan 12, 2022
@lmsurpre
issues #3184 and #3186 - update Capabilities
46f8bc4 
Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Jan 12, 2022
@lmsurpre
issues #3184 and #3186 - update Capabilities
34689af 
Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Jan 13, 2022
@lmsurpre
issues #3184 and #3186 - update Capabilities
165abdc 
Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Jan 14, 2022
@lmsurpre
issues #3184 and #3186 - update Capabilities
dba68fa 
Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Jan 20, 2022
@lmsurpre
issues #3184 and #3186 - update Capabilities
781e45c 
Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Jan 27, 2022
@lmsurpre
issues #3184 and #3186 - update Capabilities
d83414d 
Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Feb 5, 2022
@lmsurpre
issues #3184 and #3186 - update Capabilities
4fb8b79 
Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Feb 5, 2022
@lmsurpre
issues #3184 and #3186 - update Capabilities
317b502 
Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Feb 5, 2022
@lmsurpre
issues #3184 and #3186 - update Capabilities
efa9168 
Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Feb 15, 2022
@lmsurpre
issues #3184 and #3186 - update Capabilities
11f750e 
Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Feb 16, 2022
@lmsurpre
issues #3184 and #3186 - update Capabilities
b438d38 
Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Mar 9, 2022
@lmsurpre
issues #3184 and #3186 - update Capabilities
7706467 
Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Mar 9, 2022
@lmsurpre
issues #3184 and #3186 - update Capabilities
c9cadcb 
Signed-off-by: Lee Surprenant <[email protected]>
@lmsurpre lmsurpre added the r4b label Mar 30, 2022
lmsurpre added a commit that referenced this issue Mar 31, 2022
@lmsurpre
issues #3184 and #3186 - update Capabilities
96fffb7 
1. Advertise support for the system and type-level history interactions
2. Update Capabilities.getSupportedResourceTypes to use the new
ResourcesConfigAdapter

Signed-off-by: Lee Surprenant <[email protected]>
@lmsurpre lmsurpre removed the r4b label Mar 31, 2022
@lmsurpre lmsurpre changed the title Advertise type-level history in CapabilityStatement Advertise system and type-level history in CapabilityStatement Apr 1, 2022
@d0roppe
Copy link
Collaborator

d0roppe commented Apr 1, 2022

Verified the acceptance criteria, new code is working as expected.

@d0roppe d0roppe closed this as completed Apr 1, 2022
lmsurpre added a commit that referenced this issue Apr 8, 2022
@lmsurpre
issues #3184 and #3186 - update Capabilities
95df4c7 
Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Apr 22, 2022
@lmsurpre
issues #3184 and #3186 - update Capabilities
d91ad99 
Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue May 12, 2022
@lmsurpre
issues #3184 and #3186 - update Capabilities
798e74a 
Signed-off-by: Lee Surprenant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmsurpre lmsurpre

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lmsurpre @d0roppe