Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set serverRegistryResourceProviderEnabled to false in the default fhir-server-config #3001

Closed
lmsurpre opened this issue Nov 16, 2021 · 3 comments
Assignees
Labels

Comments

@lmsurpre
Copy link
Member

Is your feature request related to a problem? Please describe.
Our performance guide recommends disabling this for performance reasons, and our default (if its not specified) is to have it off I think. But our default fhir-server-config.json that gets installed has it on (presumably for CI testing reasons).

Describe the solution you'd like
Set this to false in our default fhir-server-config.json (the one that gets used by default after installing a new server / executing docker run).

Describe alternatives you've considered
keep it set to true in this default config file

Acceptance Criteria

  1. GIVEN [a precondition]
    AND [another precondition]
    WHEN [test step]
    AND [test step]
    THEN [verification step]
    AND [verification step]

Additional context
Add any other context or screenshots about the feature request here.

@prb112 prb112 added automation automation enhancement New feature or request testing labels Nov 16, 2021
@prb112
Copy link
Contributor

prb112 commented Nov 17, 2021

I thought about this a bit... perhaps this should be part of an epic to identify what we want our default to really be...

prb112 added a commit that referenced this issue Jan 26, 2022
fhir-server-config #3001

- Changes the default and tenant1 for the
serverRegistryResourceProviderEnabled
- Updated two tests to use tenant1
- Small logging fix for member-match

Signed-off-by: Paul Bastide <[email protected]>
prb112 added a commit that referenced this issue Feb 9, 2022
prb112 added a commit that referenced this issue Feb 14, 2022
…r-server-config #3001 (#3323)

* Set serverRegistryResourceProviderEnabled to false in the default fhir-server-config #3001

Signed-off-by: Paul Bastide <[email protected]>

* Update windows/migration

Signed-off-by: Paul Bastide <[email protected]>

* Update to support dynamic change to server registry

Signed-off-by: Paul Bastide <[email protected]>

* Per Review with Team

Signed-off-by: Paul Bastide <[email protected]>

* Update Builds

Signed-off-by: Paul Bastide <[email protected]>

* Update ps

Signed-off-by: Paul Bastide <[email protected]>
@lmsurpre
Copy link
Member Author

QA plan:

  1. build the docker image with our default config
  2. confirm the default/fhir-server-config.json has serverRegistryResourceProviderEnabled set to false

Separately: remove the value from the config and confirm the value still defaults to false.

@punktilious
Copy link
Collaborator

Started container as described in fhir-install/README.md.
Run

podman exec -ti fhir-server bash
vi config/default/fhir-server-config.json

Confirmed that

"serverRegistryResourceProviderEnabled": false,

Also, after enabling trace for FINE, we can see the search query executed when serverRegistryResourceProviderEnabled=true but not when it is set to false. Similarly, it is confirmed that the search query is not executed when the parameter is removed, thus confirming the default behavior is serverRegistryResourceProviderEnabled=false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants