-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test bucket endpoints #5695
Fix test bucket endpoints #5695
Conversation
I performed further testing with this change, and it wasn't sufficient still. The data_source also needs a similar update in order to provide the proper endpoint for use. I made a similar change to the data_source, and tested to verify it worked properly. |
I did some testing with the additional changes you added, and that does resolve the issues we were seeing during TF create. However, I also did some destroy testing, it it appears one of the other functions ( Sorry, I did not realize this was missed in the initial PR's to add the necessary support for COS endpoint override. |
Thanks again @cjschaef for highlighting. I have made the required changes. |
@IBM-Deeksha I fixed the golang errors and retested and this appears to now be sufficient with our needs to override COS endpoints. I can retest if necessary, once you fix the golang errors, but I expect these changes are good now. |
Done @cjschaef. Thanks for verifying. |
* add changes for test bucket endpoints * update code * fix for test cloud account url * fix endpoints in datasource * add FileFallBack check to IBMCOSBucketExists * remove hardcoded test cloud url * update code --------- Co-authored-by: Deeksha Sharma <[email protected]>
Community Note
Relates OR Closes #0000
Output from acceptance testing: