Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test bucket endpoints #5695

Merged
merged 9 commits into from
Oct 16, 2024

Conversation

IBM-Deeksha
Copy link
Contributor

  • update bucket endpoints display for test cloud account

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@cjschaef
Copy link

cjschaef commented Oct 2, 2024

I performed further testing with this change, and it wasn't sufficient still. The data_source also needs a similar update in order to provide the proper endpoint for use.

I made a similar change to the data_source, and tested to verify it worked properly.
cjschaef@31ae4aa

@cjschaef
Copy link

cjschaef commented Oct 3, 2024

I did some testing with the additional changes you added, and that does resolve the issues we were seeing during TF create.

However, I also did some destroy testing, it it appears one of the other functions (resourceIBMCOSBucketExists) in resource_ibm_cos_bucket.go is missing the FileFallBack feature, to use an overridden endpoint.
For reference, this is the change I added that appears to allow the destroy logic to find the existing resource and then delete it.
cjschaef@59085f2

Sorry, I did not realize this was missed in the initial PR's to add the necessary support for COS endpoint override.
Whether that is a separate PR or can be included in this change, I leave up to you.

@IBM-Deeksha
Copy link
Contributor Author

Thanks again @cjschaef for highlighting. I have made the required changes.

@cjschaef
Copy link

cjschaef commented Oct 9, 2024

@IBM-Deeksha I fixed the golang errors and retested and this appears to now be sufficient with our needs to override COS endpoints.
cjschaef@5238034

I can retest if necessary, once you fix the golang errors, but I expect these changes are good now.

@IBM-Deeksha
Copy link
Contributor Author

IBM-Deeksha commented Oct 11, 2024

Done @cjschaef. Thanks for verifying.

@hkantare hkantare merged commit 446909f into IBM-Cloud:master Oct 16, 2024
1 check passed
hkantare pushed a commit that referenced this pull request Oct 19, 2024
* add changes for test bucket endpoints

* update code

* fix for test cloud account url

* fix endpoints in datasource

* add FileFallBack check to IBMCOSBucketExists

* remove hardcoded test cloud url

* update code

---------

Co-authored-by: Deeksha Sharma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants