Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibm_dns_glb docs to not specify the enabled argument #3818

Open
powellquiring opened this issue Jun 2, 2022 · 8 comments
Open

ibm_dns_glb docs to not specify the enabled argument #3818

powellquiring opened this issue Jun 2, 2022 · 8 comments
Labels
documentation service/DNS Services Issues related to DNS Service

Comments

@powellquiring
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

New or Affected Resource(s) or Datasource(s)

  • ibm_dns_glb

Description

https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/dns_glb

There is no description for the enabled argument. The default is false. So without this argument the resource does not work.

image

example:

resource "ibm_dns_glb" "cloud" {
  depends_on    = [ibm_dns_glb_pool.cloud]
  name          = "backend"
  enabled       = true
  instance_id   = ibm_resource_instance.dns.guid
  zone_id       = ibm_dns_zone.widgets_com.zone_id
...

References

  • #0000
@github-actions github-actions bot added the service/DNS Services Issues related to DNS Service label Jun 2, 2022
@hkantare
Copy link
Collaborator

hkantare commented Jun 7, 2022

@gahlaut-rahul can you please look into it

@gahlaut-rahul
Copy link
Contributor

@powellquiring it is in review.

@powellquiring
Copy link
Author

Is the default documented?

@gahlaut-rahul
Copy link
Contributor

@powellquiring It is like enabled is treated as optional (it is not mandatory each optional will have some default, right ? ) and if you do not mention enabled in tf file, we do not enable the glb [check is based on key exists or not]. There is no change in that behavior. Still if you have any concern around this , we'll address.

@powellquiring
Copy link
Author

Document the default value.

@gahlaut-rahul
Copy link
Contributor

Alright @powellquiring. We'll document the default value as well.

@kavya498
Copy link
Collaborator

@powellquiring ,
There is no default value mentioned in the resource schema..
I believe API is taking the default value we are not explicitly setting any default value in schema..

@powellquiring
Copy link
Author

Since a default is accepted by the provider it's behavior should be documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation service/DNS Services Issues related to DNS Service
Projects
None yet
Development

No branches or pull requests

4 participants